Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different architectures for different platforms #1314

Closed
cawa-93 opened this issue Mar 1, 2017 · 7 comments · May be fixed by qcif/data-curator#563
Closed

Different architectures for different platforms #1314

cawa-93 opened this issue Mar 1, 2017 · 7 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@cawa-93
Copy link
Contributor

cawa-93 commented Mar 1, 2017

For example I want to create nsis installer for Windovs --ia32 --x64 and Linux deb --x64;
Perhaps there is a way to specify in the configuration area to build? Something like this:

{
  "appId": "com.electron.app",
  "compression": "maximum",
  "platforms": {
    "win": ["ia32", "x64"],
    "linux": "x64"
  }
}

In this case there is no need to specify the architecture of the platform and the command line.
Instead of this

build -wl --x64 --ia32

Suffice it to perform

build
@cawa-93 cawa-93 changed the title Different architectures for different platforms [Feature Request] Different architectures for different platforms Mar 1, 2017
@develar develar added the feature label Mar 1, 2017
@develar
Copy link
Member

develar commented Mar 1, 2017

Proposed solution: targets and n the config should accepts not only name, but object — name, arch. It also will simplify programmatic API.

Thanks for nice feature request. Will be implemented when I will return from vacation. Or PR welcome.

@cawa-93
Copy link
Contributor Author

cawa-93 commented Mar 6, 2017

@develar It shout be somsing like this:

"targets": [{
    "arch": ["ia32", "x64"],
    "platform": "win",
    "target": "nsis"
  },{
    "arch": ["ia32", "x64"],
    "platform": "linux",
    "target": "deb"
  }{
    "arch": ["x64"],
    "platform": "linux",
    "target": "snap"
  }]

After compilation we get 3 installation file:

  • .exe
  • .deb
  • .snap

@develar
Copy link
Member

develar commented Mar 6, 2017

@cawa-93 We currently already have targets in the platform specific options, so, targets will be specified in the corresponding platform specific (e.g. win, mac or linux).

So, I propose:

{
 "target": "nsis",
  "arch": ["ia32", "x64"],
}

without "platform". And you are right — target instead of name is better.

@cawa-93
Copy link
Contributor Author

cawa-93 commented Mar 6, 2017

Then maybe it should be done as follows:

{
  "win": {
    "targets": [{
      "target": "nsis",
      "arch": ["ia32", "x64"],
    }]
  },
  "linux": {
    "targets": [{
      "target": "deb",
      "arch": ["ia32", "x64"],
    }, {
      "target": "snap",
      "arch": ["x64"],
    }]
  }

The idea is to be able specify architecture to individually for each platform and each target

@develar develar changed the title [Feature Request] Different architectures for different platforms Different architectures for different platforms Mar 6, 2017
@develar
Copy link
Member

develar commented Mar 7, 2017

BTW, -w default:ia32 is supported :)

develar added a commit to develar/electron-builder that referenced this issue Mar 8, 2017
develar added a commit to develar/electron-builder that referenced this issue Mar 8, 2017
develar added a commit to develar/electron-builder that referenced this issue Mar 8, 2017
@develar develar closed this as completed in f2056fa Mar 8, 2017
@develar
Copy link
Member

develar commented Mar 8, 2017

You still need to specify platforms in the command line. build -wl --x64 --ia32 => build -wl

@timfish
Copy link
Contributor

timfish commented Apr 17, 2017

To build x64 Deb & ia32/x64 NSIS, the final syntax looks something like:

    "win": {
      "target": [
        {
          "target": "nsis",
          "arch": ["ia32", "x64"]
        }
      ]
    },
    "linux": {
      "target": [
        {
          "target": "deb",
          "arch": ["x64"]
        }
      ]
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants