Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ada #114

Merged
merged 2 commits into from
May 5, 2020
Merged

Add ada #114

merged 2 commits into from
May 5, 2020

Conversation

deepueg
Copy link
Contributor

@deepueg deepueg commented May 5, 2020

This PR adds support for setting proper ada labels for action bar menu items and up navigation

asharpbflat
asharpbflat approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@asharpbflat asharpbflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

friederbluemle
friederbluemle approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Build should pass after rebase

@friederbluemle friederbluemle mentioned this pull request May 5, 2020
Open
@deepueg deepueg merged commit 48752c5 into electrode-io:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharpbflat asharpbflat asharpbflat approved these changes

@friederbluemle friederbluemle friederbluemle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepueg @friederbluemle @asharpbflat