Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove and update dependencies #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove and update dependencies #113

wants to merge 1 commit into from

Conversation

friederbluemle
Copy link
Member

Remove some unused files and dependencies to make the project dependencies tree more clear.

Also contains a couple of minor updates:

  • androidx.lifecycle:lifecycle-extensions: 2.1.0 -> 2.2.0
  • com.google.android.material:material: 1.1.0 -> 1.2.0

@deepueg - Question: Does :lib require the declaration with api visibility on the container? If yes, in which case is it necessary?

@friederbluemle friederbluemle requested a review from deepueg May 5, 2020 04:26
deepueg
deepueg requested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@deepueg deepueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the plugin config

@friederbluemle
Copy link
Member Author

Good point, thanks @deepueg - I'll push the updated branch after you merge #114

@friederbluemle friederbluemle force-pushed the remove-unused-deps branch 2 times, most recently from f419fcf to d0d02a1 Compare September 24, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepueg deepueg deepueg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friederbluemle @deepueg