Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italy bidding zones (GeoJSON) #1536

Closed
wants to merge 4 commits into from

Conversation

antifa-ev
Copy link

No description provided.

@antifa-ev antifa-ev changed the title I've added GeoJSON for the Italian bidding zones based on OpenStreetMap boundaries. Add Italy bidding zones (GeoJSON) Jul 30, 2018
@antifa-ev antifa-ev mentioned this pull request Jul 30, 2018
@alixunderplatz
Copy link
Collaborator

@antifa-ev Wow, this absolutely made my day/night! 😃😃😃
Awesome, thank you so much!!!!!

Zones all look good to me!
@corradio is there any advantage/disadvantage of having these seperate GeoJSONs compared with "merging the regions the old way" like for the US, Russia etc. in generate-geometries.js?

@corradio
Copy link
Member

I think it's easier to maintain if we extract them from Natural Earth instead of having custom polygons.
Also the boundaries between countries might be more robust.
@antifa-ev can you tell us a bit about how you extracted the polygons? Is it the aggregation of Italian regions? In that case it might be simpler to extract them using generate-geometries.js.

Very excited about splitting Italy!

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative! When I import the shapes into mapshaper I get a json parse error with IT-SIC, the others are fine.

@antifa-ev
Copy link
Author

@corradio I've downloaded the boundaries from OpenStreetMap, reprocessed them (deleted all islands) and simplified them with simplify-geojson.

I could simplify them in a matter, that adjacent boundaries share the same simplification. But this would involve PostGIS, so I would like to avoid it!

And: I've indeed forgotten to fix Sicily.

@corradio
Copy link
Member

Hi @antifa-ev,
Thanks for the clarifications. However, do the individual areas correspond to regions? If that's the case, it might be better to use the generate-geometries.js script which will take care of everything for you, and will be more robust.

@antifa-ev
Copy link
Author

@corradio What do you mean with do the individual areas correspond to regions?

I've merged Italian administrative regions into network regions, as demanded.

@corradio
Copy link
Member

@antifa-ev can you ping me on Slack? It will be easier!

@jarek
Copy link
Collaborator

jarek commented Jul 31, 2018

First thing I'm seeing is that these are LineStrings and our other maps use Polygons. That should be a really minor change though.

@jarek
Copy link
Collaborator

jarek commented Jul 31, 2018

From second glance, this should be doable from Natural Earth geometries by merging on region_cod, e.g. Toscana is region_cod=IT-52 (and there are several subdivisions of it - Grosseto, Livorno, Pisa, Siena... but they all have the same region_code).

To preview the Natural Earth, download the file http://naciscdn.org/naturalearth/10m/cultural/ne_10m_admin_1_states_provinces_lakes.zip (this is referenced in https://github.com/tmrowco/electricitymap-contrib/blob/master/web/topogen.sh), then upload it to http://mapshaper.org. Using the "i" icon in top-right you can preview properties of the regions.

@jarek
Copy link
Collaborator

jarek commented Jul 31, 2018

We might need to extend https://github.com/tmrowco/electricitymap-contrib/blob/master/web/generate-geometries.js#L65 to enable selection by region_cod

@corradio corradio mentioned this pull request Sep 17, 2018
4 tasks
@corradio
Copy link
Member

Closed in favor of #1604

@corradio corradio closed this Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants