Split ES-IB [work in progress] #1448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES-IB-MA: Mallorca (connected with ES, ES-IB-ME and ES-IB-IZ ES-IB-ME: Menorca (connected with ES-IB-MA, power cable currently broken ES-IB-IZ: Ibiza (connected with ES-IB-MA and ES-IB-FO) ES-IB-FO: Formentera (connected with ES-IB-IZ)
uncommented "import ParserException" hoping checks won't fail afterwards
|
First pass things seem generally correct. CircleCI is failing due to the tests being out of date, easy fix there. |
Enable verification, map waste to biomass, tidy up printing
|
Actually I was wrong about the tests being an easy fix, there's more changes required than I thought. @BLACKLEG do you want to have a try at altering them? |
|
@BLACKLEG are you able to help here? |
|
Hi @corradio, I can help with it. Could you divide Balearic islands shape into islands? |
|
I think @systemcatch has a good handle on this - else I can help. |
|
Hi @BLACKLEG I will do my best to split the islands into separate shapes, can you work on fixing the tests. I don't think the shapes will interfere with them. |
|
No worries, you can do `git revert` from the the PR (which will create a
commit that cancels the previous commit).
I suggest you copy/paste the file to a new branch/PR. Write us on slack
#electricitymap else, and we'll help!
Olivier
…On Tue, Jul 31, 2018 at 4:25 PM antifa-ev ***@***.***> wrote:
@corradio <https://github.com/corradio> I've done a git mistake. I've
wanted to create a new pull request "GeoJSON for Mallorca" for this topic.
But it was appended to my last pull request at #1536
<#1536>
Do you know how to fix this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1448 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABlEKLorbUpHNlc6RlfymKiBtKHNZVTQks5uMGjqgaJpZM4Uhgyd>
.
|
Merged
|
Closing this in favor of #1580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt for a parser splitting the generation on the Balearic islands.
ref #1347
As usual, feel free to comment and improve diectly, so we can move on to the next steps.
I copied and adapted most of the code from ES_CN.
Some things are commented out (and in In fetch production, there is no "logger=logging.getLogger(name)" like in ES-CN) because I had local issues and I'm far, far away from being an expert in terms of Python ;)