fix: Error not showing in failed test result flyout #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
kyungeunni
approved these changes
Apr 29, 2022
No blame, just forgive me the next 100 times I do something similar 😆 I actually want to add some tests to prevent this problem happening again. I suppose I can merge the fix here and then add them in a follow-up though as we definitely want to get this in before our next release. |
|
Issue to add tests: #235. |
v1v
added a commit
to v1v/synthetics-recorder
that referenced
this pull request
May 11, 2022
…-report * upstream/main: fix: Refresh action title on update (elastic#237) feat: Add a controller class for browser process requests (elastic#241) fix: Do not generate code when wrong data is passed or when unnecessary (elastic#239) 0.0.1-alpha.4 fix: Hoist page objects in generated code (elastic#211) Fix bug issue. (elastic#233) chore: Move `createAction` test helpers to top level of repo (elastic#231) ci: refactor the docker build stage (elastic#227) Add status indicator to assertion elements. (elastic#226) ci: report test results (elastic#223) chore: convert electron js to ts (elastic#205)
|
POST FF Testing LGTM it shows an error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a defect we introduced recently as part of the backend transition from pure JS to TypeScript. I'm going to add tests for this function so we don't fail to notice things like this in the future.
Before
After
Implementation details
We simply forgot to include an optional field in the response from the test procedure.
How to validate this change
Run a journey that you expect to fail, and observe the code/data info in the test result flyout.