Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other] Add tests to onTest electron code #235

Open
justinkambic opened this issue Apr 29, 2022 · 0 comments
Open

[Other] Add tests to onTest electron code #235

justinkambic opened this issue Apr 29, 2022 · 0 comments
Assignees
Labels
chore tech debt Indicates a change we should implement to correct or modify past code/technology decisions

Comments

@justinkambic
Copy link
Contributor

Task summary

We recently fixed a bug that caused the error messages from Playwright not to show in the recorder. This happened because we merged a change that removed an optional field from the result object.

As a follow-up to this fix we should focus on refactoring the execution.ts file to be more testable and add tests to ensure the output remains consistent when subjected to changes.

Linked resources

PR that inspired the issue: #233

Additional information

No response

@justinkambic justinkambic added chore tech debt Indicates a change we should implement to correct or modify past code/technology decisions labels Apr 29, 2022
@justinkambic justinkambic self-assigned this May 5, 2022
@kyungeunni kyungeunni mentioned this issue Aug 24, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore tech debt Indicates a change we should implement to correct or modify past code/technology decisions
Projects
None yet
Development

No branches or pull requests

1 participant