Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds text about data types and categorization to Anomaly Detection overview page #809

Closed
wants to merge 10 commits into from

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jan 15, 2020

This PR explains that categorization works best on machine-generated content.

Preview available here: http://stack-docs_809.docs-preview.app.elstc.co/guide/en/machine-learning/master/ml-datatypes-categorization.html

@lcawl
Copy link
Contributor

lcawl commented Jan 15, 2020

I wonder if this information shouldn't be merged into this page instead: https://www.elastic.co/guide/en/machine-learning/master/ml-configuring-categories.html

I have other updates planned for that page too (to show the use of the new categorization wizard)

@szabosteve
Copy link
Contributor Author

@lcawl I think this text could be a sub-section of the page that you linked, sure! I'll replace the content after the review.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions, but maybe my wording could be improved.

@szabosteve
Copy link
Contributor Author

@droberts195 Thank you for the review. I applied your suggestions.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve
Copy link
Contributor Author

I relocate the text to an already existing asciidoc file in the ES docs repo to have all the info about categorization in the same place. elastic/elasticsearch#51145

@szabosteve szabosteve closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants