Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total merges and refreshes in summary output #614

Closed
dliappis opened this issue Dec 6, 2018 · 0 comments · Fixed by #615
Closed

Add total merges and refreshes in summary output #614

dliappis opened this issue Dec 6, 2018 · 0 comments · Fixed by #615
Assignees
@dliappis
Labels
enhancement Improves the status quo :Reporting Command line reporting

Comments

@dliappis
Copy link
Contributor

dliappis commented Dec 6, 2018 •
edited
Loading

Currently our summary output includes sections like:

|   All |                   Total refresh time |                            |   131.531 |    min |
|   All |           Min refresh time per shard |                            |   43.0791 |    min |
|   All |        Median refresh time per shard |                            |   44.0437 |    min |
|   All |           Max refresh time per shard |                            |   44.4079 |    min |

i.e. only times not count.

Given #608 we can't rely too much on node-stats atm, so makes sense to also present the Total refreshes / Total merges (maybe an avg rate too based on total time?)
@dliappis dliappis self-assigned this Dec 6, 2018
@dliappis dliappis added enhancement Improves the status quo :Reporting Command line reporting labels Dec 6, 2018
dliappis added a commit to dliappis/rally that referenced this issue Dec 10, 2018
@dliappis
Add refresh/merge/flush totals in summary
ced08a4 
Due to elastic#608 it's likely we need to benchmark scenarios without using
the node-stats telemetry device. At the same time we want to get a
general idea of how many refreshes/merges/flushes happened (in total)
by accessing the index stats.

Add total count for merges/refresh/flush in summary output; this is
collected from `_all/primaries` in `_stats`.

Also modify summary description to clarify the values are totals from
primary shards.

Finally fix bug where index stats where time/count == 0 got skipped
from the summary.

Closes elastic#614
@dliappis dliappis mentioned this issue Dec 10, 2018
Merged
dliappis added a commit that referenced this issue Dec 14, 2018
@dliappis
Add refresh/merge/flush totals in summary
be6336c 
Due to #608 it's likely we need to benchmark scenarios without using
the node-stats telemetry device. At the same time we want to get a
general idea of how many refreshes/merges/flushes happened (in total)
by accessing the index stats.

Add total count for merges/refresh/flush in summary output; this is
collected from `_all/primaries` in `_stats`.

Also that these values are cumulatives from primary shards and also 
clarify desciprion for min/median/max in the summary report.

Finally fix bug where index stats where time/count == 0 got skipped
from the summary.

Closes #614

Relates: #615
Relates: elastic/elasticsearch#35594 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dliappis dliappis

Labels
enhancement Improves the status quo :Reporting Command line reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add refresh/merge/flush totals in summary dliappis/rally
1 participant
@dliappis