Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for Kibana knowledge base entry assets (#807)" #813

Merged
merged 3 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion code/go/internal/validator/content.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ func validateContentType(fsys fs.FS, path string, contentType spectypes.ContentT
}
}
case "application/json":
case "application/x-ndjson":
case "text/markdown":
case "text/plain":
default:
Expand Down
8 changes: 0 additions & 8 deletions code/go/pkg/validator/validator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func TestValidateFile(t *testing.T) {
"custom_ilm_policy": {},
"profiling_symbolizer": {},
"logs_synthetic_mode": {},
"knowledge_base": {},
"bad_additional_content": {
"bad-bad",
[]string{
Expand Down Expand Up @@ -228,13 +227,6 @@ func TestValidateFile(t *testing.T) {
`field data_stream.vars.data_stream.dataset: Does not match pattern '^[a-zA-Z0-9]+[a-zA-Z0-9\._]*$'`,
},
},
"bad_knowledge_base": {
"index_data/foo/manifest.yml",
[]string{
`field (root): index is required`,
`field (root): Additional property unknown is not allowed`,
},
},
}

for pkgName, test := range tests {
Expand Down
3 changes: 0 additions & 3 deletions spec/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
- description: Add support for content packages.
type: enhancement
link: https://github.com/elastic/package-spec/pull/777
- description: Add support for "Kibana knowledge base entry" assets.
type: enhancement
link: https://github.com/elastic/package-spec/pull/807
- description: Add support for semantic_text field definition
type: enhancement
link: https://github.com/elastic/package-spec/pull/807
Expand Down
69 changes: 0 additions & 69 deletions spec/content/index_data/manifest.spec.yml

This file was deleted.

33 changes: 0 additions & 33 deletions spec/content/index_data/spec.yml

This file was deleted.

5 changes: 0 additions & 5 deletions spec/content/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ spec:
name: kibana
required: false
$ref: "./kibana/spec.yml"
- description: Folder containing Index data assets used by the package
type: folder
name: index_data
required: false
$ref: "./index_data/spec.yml"
- description: Configuration file to process the results returned from the package validation. This file is just for package validation and it should be ignored when installing or using the package.
type: file
contentMediaType: "application/x-yaml"
Expand Down
2 changes: 1 addition & 1 deletion spec/integration/kibana/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ spec:
contentMediaType: "application/json"
pattern: '^{PACKAGE_NAME}-.+\.json$'
forbiddenPatterns:
- '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden
- '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden
versions:
- before: 3.3.0
patch:
Expand Down
93 changes: 0 additions & 93 deletions test/packages/bad_knowledge_base/LICENSE.txt

This file was deleted.

5 changes: 0 additions & 5 deletions test/packages/bad_knowledge_base/changelog.yml

This file was deleted.

1 change: 0 additions & 1 deletion test/packages/bad_knowledge_base/docs/README.md

This file was deleted.

Binary file not shown.
1 change: 0 additions & 1 deletion test/packages/bad_knowledge_base/img/system.svg

This file was deleted.

Loading