Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for Kibana knowledge base entry assets (#807)" #813

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

pgayvallet
Copy link
Contributor

What does this PR do?

Reverts #807

@pgayvallet pgayvallet marked this pull request as ready for review October 9, 2024 11:31
@pgayvallet pgayvallet requested a review from a team as a code owner October 9, 2024 11:31
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for preparing the revert!

Comment on lines 13 to 15
- description: Add support for semantic_text field definition
type: enhancement
link: https://github.com/elastic/package-spec/pull/807
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should stay, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to recover this entry. Will auto-merge if CI passes.

@jsoriano jsoriano enabled auto-merge (squash) October 10, 2024 17:33
@jsoriano jsoriano disabled auto-merge October 10, 2024 17:33
@jsoriano jsoriano enabled auto-merge (squash) October 10, 2024 17:33
@jsoriano jsoriano merged commit 3afde74 into elastic:main Oct 10, 2024
3 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants