Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable check to avoid duplicated fields #331

Closed
5 tasks done
jsoriano opened this issue May 12, 2022 · 1 comment · Fixed by #384
Closed
5 tasks done

Enable check to avoid duplicated fields #331

jsoriano opened this issue May 12, 2022 · 1 comment · Fixed by #384
Assignees
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@jsoriano
Copy link
Member

jsoriano commented May 12, 2022

This is a follow up of #309.

We have found some issues we have to investigate. It seems that elastic-package is importing more fields than expected when using external: ecs, what complicates checking for fields duplication.
Also, fields validator in elastic-package uses only the fields defined in the source files, so it is sometimes not possible to pass both the validation of defined fields, and the validation to avoid duplicated fields. Original idea of the fields importer was to import only fields defined explicitly and not subfields of groups, so it is ok if fields validator only uses the source files.

So current plan is going to be:

@jsoriano
Copy link
Member Author

Blocking this issue till we have #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
1 participant