Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import ECS fields of type group #818

Merged
merged 3 commits into from
May 12, 2022

Conversation

jsoriano
Copy link
Member

elastic-package build doesn't import anymore fields of type group, or groups without subfields.

Before this change, it imported fields of type group and all its subfields, what was unexpected (see elastic/package-spec#331).

A check is also added to don't allow to store values in names of fields of type group.

@jsoriano jsoriano requested a review from a team May 12, 2022 11:47
@jsoriano jsoriano self-assigned this May 12, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T11:47:41.810+0000

  • Duration: 33 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 703
Skipped 0
Total 703

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (30/30) 💚
Files 64.22% (70/109) 👍
Classes 58.278% (88/151) 👍
Methods 47.555% (282/593) 👍 0.089
Lines 32.282% (2601/8057) 👍 0.287
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano merged commit 86c08f2 into elastic:main May 12, 2022
@jsoriano jsoriano deleted the dont-import-nested-ecs-fields branch May 12, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants