Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated fields definitions #3392

Closed
wants to merge 18 commits into from

Conversation

jsoriano
Copy link
Member

What does this PR do?

Remove duplicated fields.

This is important to avoid unexpected results, when definitions are different any of them could be applied.

This is also a requirement to use package-spec 1.8.0.

See elastic/package-spec#309.

Related issues

Screenshots

@jsoriano jsoriano self-assigned this May 19, 2022
go.mod Outdated
@@ -164,3 +164,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace github.com/elastic/package-spec => github.com/jsoriano/package-spec v0.0.0-20220519154435-520b485f62c0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reverted. Includes elastic/package-spec#338.

@elasticmachine
Copy link

elasticmachine commented May 19, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-08T22:11:23.141+0000

  • Duration: 93 min 56 sec

Test stats 🧪

Test Results
Failed 2
Passed 4776
Skipped 7
Total 4785

Test errors 2

Expand to view the tests failures

Check integrations / mysql / mysql: check / system test: default (variant: percona_5_7_24) – mysql.slowlog
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in documents stored in logs-mysql.slowlog-ep data stream: [0] found error.message in event: Provided Grok expressions do not match field value: [time: 0.000051  Lock_time: 0.000021 Rows_sent: 0  Rows_examined: 0\nSET timestamp=1654728872;\nINSERT INTO time_zone_name (Name, Time_zone_id) VALUES ('right/NZ-CHAT', @time_zone_id);] 
    

Check integrations / mysql / mysql: check / system test: default (variant: mariadb_10_2_23) – mysql.slowlog
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in documents stored in logs-mysql.slowlog-ep data stream: [0] found error.message in event: Provided Grok expressions do not match field value: [@Host: root[root] @ localhost []  Id:     3\n# Query_time: 0.000021  Lock_time: 0.000000 Rows_sent: 0  Rows_examined: 0\nSET timestamp=1654728973;\nSET @time_zone_id= LAST_INSERT_ID();] 
    

Steps errors 3

Expand to view the steps failures

Test integration: aws
  • Took 12 min 52 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Boot up the Elastic stack
  • Took 2 min 49 sec . View more details here
  • Description: ../../build/elastic-package stack up -d -v --version 7.15.0
Test integration: mysql
  • Took 18 min 47 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 24, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (248/248) 💚
Files 96.69% (409/423) 👍 0.123
Classes 96.69% (409/423) 👍 0.123
Methods 89.575% (4219/4710) 👍 0.686
Lines 89.676% (76938/85796) 👎 -0.082
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano changed the title Check duplicated fields Remove duplicated fields definitions May 30, 2022
@jsoriano
Copy link
Member Author

/test

@jsoriano
Copy link
Member Author

Closing this by now, we will wait to have something like elastic/package-spec#345, so packages can be updated one by one.

@jsoriano jsoriano closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants