-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated fields definitions #3392
Conversation
go.mod
Outdated
@@ -164,3 +164,5 @@ require ( | |||
sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect | |||
sigs.k8s.io/yaml v1.3.0 // indirect | |||
) | |||
|
|||
replace github.com/elastic/package-spec => github.com/jsoriano/package-spec v0.0.0-20220519154435-520b485f62c0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be reverted. Includes elastic/package-spec#338.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
🌐 Coverage report
|
1bda00e
to
2582302
Compare
2582302
to
2e0a456
Compare
/test |
Closing this by now, we will wait to have something like elastic/package-spec#345, so packages can be updated one by one. |
What does this PR do?
Remove duplicated fields.
This is important to avoid unexpected results, when definitions are different any of them could be applied.
This is also a requirement to use package-spec 1.8.0.
See elastic/package-spec#309.
Related issues
Screenshots