Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] Add lightweight to list of directories created on init #2755

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

colleenmcginnis
Copy link
Contributor

Addresses #2593 (review):

When a new folder has been init we separate out the browser and lightweight examples

  • The journeys folder just contains the browser examples
  • The lightweight folder contains an example heartbeat.yml

So the info is mostly correct, just needs rearranging on the page a bit.

Making this change separately from #2593 so it can be backported to 8.6.

@colleenmcginnis colleenmcginnis added backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify labels Mar 10, 2023
@colleenmcginnis colleenmcginnis self-assigned this Mar 10, 2023
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner March 10, 2023 19:22
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@paulb-elastic
Copy link
Contributor

@colleenmcginnis I think the section following these changes will need updating a little too (from line 107).

The description and code snippets will need swapping round and updating a little.

Copy link
Contributor

@paulb-elastic paulb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colleenmcginnis I think the section following these changes will need updating a little too (from line 107).

The description and code snippets will need swapping round and updating a little.

@colleenmcginnis
Copy link
Contributor Author

@colleenmcginnis I think the section following these changes will need updating a little too (from line 107).

Ahh you're right! 🙈

I also found and replaced one other reference on the Configure lightweight monitors page (in the first bullet point).

Copy link
Contributor

@paulb-elastic paulb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @colleenmcginnis

@colleenmcginnis colleenmcginnis merged commit 74242e8 into elastic:main Mar 21, 2023
@colleenmcginnis colleenmcginnis deleted the synthetics-init-fix branch March 21, 2023 17:15
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
…t` (#2755)

* add lightweight to list of directories

* replace more references to journeys dir with lightweight dir

(cherry picked from commit 74242e8)
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
…t` (#2755)

* add lightweight to list of directories

* replace more references to journeys dir with lightweight dir

(cherry picked from commit 74242e8)
colleenmcginnis added a commit that referenced this pull request Mar 21, 2023
…t` (#2755) (#2779)

* add lightweight to list of directories

* replace more references to journeys dir with lightweight dir

(cherry picked from commit 74242e8)

Co-authored-by: Colleen McGinnis <[email protected]>
colleenmcginnis added a commit that referenced this pull request Mar 21, 2023
…t` (#2755) (#2780)

* add lightweight to list of directories

* replace more references to journeys dir with lightweight dir

(cherry picked from commit 74242e8)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants