Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Synthetics UI #2593

Merged
merged 18 commits into from
Mar 21, 2023
Merged

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Feb 8, 2023

Closes #2401
Closes #2549

A couple weeks ago, @drewpost @paulb-elastic and I met to talk about how to handle the existence of both Uptime and Synthetics (beta) in the 8.7 release. We discussed:

  • Splitting Uptime and Synthetics content into separate top-level sections:
    • The Uptime section should only discuss setting up with Heartbeat and creating lightweight monitors (similar to what was available in the 8.1 documentation).
    • The Synthetics section should include setting up with both project monitors and the Synthetics UI and creating both lightweight and browser monitors.
  • All screenshots should be updated to reflect changes to the UI.
  • All user workflows should be updated to reflect changes to the UI.
  • The docs should cover the new Synthetics UI's empty state.
  • The migration doc should point to the Synthetics UI instead of the Uptime app.
  • Some content will need to be reviewed to determine if it relevant to Uptime, Synthetics, or both including:

I have two requests for @drewpost @paulb-elastic and @andrewvc before making changes to docs:

  • Does this plan still sound good to you?
  • If yes, can you please take a look at the preview site (with separate Uptime and Synthetics sections) and let me know if this aligns with what you're thinking? So far all I've done in this PR is prepare the structure and add some placeholders where I know content will need to be updated and/or written.

@colleenmcginnis colleenmcginnis added the backport-8.7 Automated backport with mergify label Feb 8, 2023
@colleenmcginnis colleenmcginnis self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

A documentation preview will be available soon:

@paulb-elastic
Copy link
Contributor

Thanks for putting this together @colleenmcginnis. I really like this new layout. It finally gives a much better separation we were waiting for but couldn’t do because of having to use Uptime Monitor Management during this transition.

@andrewvc
Copy link
Contributor

andrewvc commented Feb 9, 2023

I concur with @paulb-elastic , this is a breath of fresh air. Looks great.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

This pull request is now in conflict. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2401 upstream/issue-2401
git merge upstream/main
git push upstream issue-2401

* add info on alerting settings

* add info on private locations settings

* add info on global parameters, data retention, and api keys
@colleenmcginnis colleenmcginnis marked this pull request as ready for review February 27, 2023 17:45
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner February 27, 2023 17:45
@colleenmcginnis
Copy link
Contributor Author

colleenmcginnis commented Feb 27, 2023

@paulb-elastic this PR is ready for review. Any and all feedback is welcome, but here's the specific feedback I need from the Synthetics team to get this foundation of Synthetics UI docs merged (then we can address other open issues in smaller PRs that are easier to review):

Feel free to tag in others to review, and let me know if you have questions for me! I'll plan to do a final pass for redirects, grammar, etc after I know the updated content is correct.

@paulb-elastic
Copy link
Contributor

@colleenmcginnis this is great, thanks for the details of the links to the page/preview and existing version, very helpful.

I've looked at docs/en/observability/synthetics-analyze.asciidoc so far and will continue the others tomorrow

@paulb-elastic
Copy link
Contributor

@colleenmcginnis thanks again for putting all this together. I think I have gone through everything you were asking for input on, but lmk if you need anything else from me.

Copy link
Contributor Author

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulb-elastic! I addressed your comments and left a few additional questions below.

Up next: I'll do a close pass through all content for consistency and spelling/grammar.

docs/en/observability/synthetics-analyze.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/synthetics-analyze.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/synthetics-intro.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/uptime-intro.asciidoc Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2023

This pull request is now in conflict. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2401 upstream/issue-2401
git merge upstream/main
git push upstream issue-2401

Copy link
Contributor

@paulb-elastic paulb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a single comment, and am making a further comment below, but none that block this from being a LGTM.

Here's something I saw when reviewing, not part of this PR, but should be updated.

So the info is mostly correct, just needs rearranging on the page a bit.

@colleenmcginnis colleenmcginnis merged commit 56cfb75 into elastic:main Mar 21, 2023
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
* split uptime and synthetics

* update getting started flows

* clean up scripting section

* update filenames

* update references to private locations

* clean up

* add details to the analyze monitor data page

* Add Synthetics settings page (#1)

* add info on alerting settings

* add info on private locations settings

* add info on global parameters, data retention, and api keys

* address feedback from @paulb-elastic

* address additional feedback

* use consistent language

* add note about 'run test manually' only being available for public locations

* remove journeys from uptime analyze section

* add one more redirect

(cherry picked from commit 56cfb75)
colleenmcginnis added a commit that referenced this pull request Mar 21, 2023
* split uptime and synthetics

* update getting started flows

* clean up scripting section

* update filenames

* update references to private locations

* clean up

* add details to the analyze monitor data page

* Add Synthetics settings page (#1)

* add info on alerting settings

* add info on private locations settings

* add info on global parameters, data retention, and api keys

* address feedback from @paulb-elastic

* address additional feedback

* use consistent language

* add note about 'run test manually' only being available for public locations

* remove journeys from uptime analyze section

* add one more redirect

(cherry picked from commit 56cfb75)

Co-authored-by: Colleen McGinnis <[email protected]>
@colleenmcginnis colleenmcginnis deleted the issue-2401 branch November 26, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.7 Automated backport with mergify
Projects
None yet
4 participants