[ML] Parse JSON format config updates #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expect configuration update requests to be received in JSON formatted strings. Remove support for old, ini file parsing.
droberts195
approved these changes
Jan 20, 2021
lib/api/CConfigUpdater.cc
Outdated
Comment on lines
25
to
26
| LOG_ERROR(<< "An error occurred while parsing pattern set from JSON: " + | ||
| std::string(rapidjson::GetParseError_En(doc.GetParseError()))); |
There was a problem hiding this comment.
Suggested change
| LOG_ERROR(<< "An error occurred while parsing pattern set from JSON: " + | |
| std::string(rapidjson::GetParseError_En(doc.GetParseError()))); | |
| LOG_ERROR(<< "An error occurred while parsing pattern set from JSON: " | |
| << rapidjson::GetParseError_En(doc.GetParseError())); |
include/api/CConfigUpdater.h
Outdated
| @@ -24,13 +24,13 @@ namespace api { | |||
| //! update, a control message is being sent with the requested | |||
| //! configuration changes. This class is responsible for parsing | |||
| //! text with the requested configuration changes and apply them. | |||
| //! The changes are expected in an ini type of syntax. | |||
| //! The changes are expected in an JSON formatted syntax. | |||
There was a problem hiding this comment.
Suggested change
| //! The changes are expected in an JSON formatted syntax. | |
| //! The changes are expected in a JSON document. |
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Jan 21, 2021
* Expect configuration update requests to be received in JSON formatted strings. * Remove support for old, ini file parsing. Relates elastic/elasticsearch#67721, elastic#1253
This was referenced Jan 21, 2021
edsavage
added a commit
that referenced
this pull request
Jan 21, 2021
* Expect configuration update requests to be received in JSON formatted strings. * Remove support for old, ini file parsing. Relates elastic/elasticsearch#67721, #1253 Backports #1682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect configuration update requests to be received in JSON formatted
strings. Remove support for old, ini file parsing.
Relates elastic/elasticsearch#67721, #1253