[ML] Send autodetect config updates as JSON #67721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send configuration updates to model plot, scheduled events, detector rules and filters as JSON formatted strings. Remove any now unneeded supporting code.
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
approved these changes
Jan 20, 2021
| writeMessage(stringBuilder.toString()); | ||
| } | ||
|
|
||
| public void writeUpdateScheduledEventsMessage(List<ScheduledEvent> events, TimeValue bucketSpan) throws IOException { | ||
| StringBuilder stringBuilder = new StringBuilder(); | ||
| stringBuilder.append(UPDATE_MESSAGE_CODE).append("[scheduledEvents]\n"); | ||
| if (events.isEmpty()) { | ||
| stringBuilder.append("clear = true\n"); |
There was a problem hiding this comment.
So if we now have an empty list of events, c++ will receive an empty events array. Will this clear any existing events?
There was a problem hiding this comment.
Yes, the C++ code has been adjusted such that an empty events array, generating the message u{"events":[]} will clear out any existing events.
|
jenkins retest this please |
edsavage
added a commit
to edsavage/elasticsearch
that referenced
this pull request
Jan 20, 2021
Send configuration updates to model plot, scheduled events, detector rules and filters as JSON formatted strings. Remove any now unneeded supporting code.
edsavage
added a commit
that referenced
this pull request
Jan 20, 2021
edsavage
added a commit
to elastic/ml-cpp
that referenced
this pull request
Jan 21, 2021
* Expect configuration update requests to be received in JSON formatted strings. * Remove support for old, ini file parsing. Relates elastic/elasticsearch#67721, #1253
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Jan 21, 2021
* Expect configuration update requests to be received in JSON formatted strings. * Remove support for old, ini file parsing. Relates elastic/elasticsearch#67721, elastic#1253
This was referenced Jan 21, 2021
edsavage
added a commit
to elastic/ml-cpp
that referenced
this pull request
Jan 21, 2021
* Expect configuration update requests to be received in JSON formatted strings. * Remove support for old, ini file parsing. Relates elastic/elasticsearch#67721, #1253 Backports #1682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send configuration updates to model plot, scheduled events, detector
rules and filters as JSON formatted strings.
Remove any now unneeded supporting code.
Note that a handful of test cases have been muted. This is only temporary and the tests will be re-enabled when the supporting C++ code is merged and available.