Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8126
This is mostly a rewrite of the windows launching batch files, inspired by the ES windows launch batch files.
The initial goal was to add support for the
config/jvm.options
in its default location or in--path.settings
if specified on the command line.Here are the differences from the linux launching logic:
JAVA_OPTS
env var is now ignored, ES is also doing thisJAVA_TOOL_OPTIONS
env var is cleared, ES is also doing thisLS_JAVA_OPTS
env var is supported to append options to parsed options in thejvm.options
file.USE_RUBY
andUSE_DRIP
env vars. These were meant for development purposes and are not used anymore I believe.This also includes a fix in
runner.rb
which was creating an invalid URI for the path specified for--path.settings
command line option.