-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discuss] unify launch scripts options support #8261
Comments
I still use USE_RUBY but only as a desparate workaround. I am OK if it is removed. +1 on unifying (it should make user experience better, documentation easier, and maintenance simpler) |
+1 also makes #8161 much easier (replicating the current shell behaviour there turned out to be very tricky :)) |
+1 to unify, and +1 to make the 6.0.0 release, since this is non-passive. |
@jakelandis it's a bit late in the game for 6.0.0, but if we feel confident in the change (once merged), I would be OK with it landing for 6.0.0 (assuming the ship hasn't already sailed). |
+1 to all your points. We should get this for 6.0 if possible. |
+1 to everything , +1 for 6.0 release. |
ok, lets do this, quorum is met 😅 |
PR in #8285 |
remove dripmain.rb
#8285 new Linux launch scripts merged in master, 6.x and 6.0 |
The new Windows launch scripts in #8178 is changing some behaviours from the Linux launch scripts:
JAVA_OPTS
env var is now ignored, ES is also doing thisJAVA_TOOL_OPTIONS
env var is cleared, ES is also doing thisLS_JAVA_OPTS
env var is supported to append options to parsed options in thejvm.options
file.USE_RUBY
andUSE_DRIP
env vars. These not used anymore I believe.My proposal is to also apply these changes to the Linux launch scripts.
WDYT?
The text was updated successfully, but these errors were encountered: