Allow Logstash to write its logs in JSON format #5277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is made available by a --log-in-json flag. Default is false. When false, the old behavior [1] is used. When true, JSON logs are emitted. [1] The old behavior is realy two things. First, using Object#inspect to serialize. Second, to color the output if the IO is a tty. For #1569 This is a manual backport of PR #4820 into the 2.x branch.
|
With a clean checkout of the repository. After doing: When I start logstash with this line it crash. :( |
|
Hmm, kind of annoying that the tests don't catch something this simple. I'll see what I can do. |
|
@ph fixed. |
| @@ -480,7 +480,7 @@ def start_pipeline(id) | |||
| begin | |||
| pipeline.run | |||
| rescue => e | |||
| @logger.error("Pipeline aborted due to error", :exception => e, :backtrace => e.backtrace) | |||
| @logger.error("Pipeline aborted due to error", :exception => e.class.name, :backtrace => e.backtrace) | |||
There was a problem hiding this comment.
This is somewhat common to use this kind of line in the plugins, I've seen it a lot and I have use it myself.
|
It fixed the issue for me, @jordansissel 2.4/5.0 beta absolutely need to go out with the new version of jrjackson, guyboertje/jrjackson#54 |
|
The code LGTM. |
|
@ph +1 on shipping 2.4/5.0beta1 with a newer jrjackson |
|
@jordansissel I have created this #5278 to make sure we dont drop the ball. I am +1 to merge your changes. |
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 10, 2016
This is made available by a --log-in-json flag. Default is false. When false, the old behavior [1] is used. When true, JSON logs are emitted. [1] The old behavior is realy two things. First, using Object#inspect to serialize. Second, to color the output if the IO is a tty. For #1569 This is a manual backport of PR #4820 into the 2.x branch. Fixes #5277
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 10, 2016
This was referenced May 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Logstash to write its logs in JSON format
This is made available by a --log-in-json flag. Default is false.
When false, the old behavior [1] is used.
When true, JSON logs are emitted.
[1] The old behavior is really two things. First, using Object#inspect to
serialize. Second, to color the output if the IO is a tty.
For #1569
This is a manual backport of PR #4820 into the 2.x branch.