[Security Solutions][Timeline] Added createFrom in action to hide #98144

semd · 2021-04-23T14:19:14Z

Summary

Create template from timeline action button hidden in the "open timeline" and "Import query from saved timeline" modals.

This is a fix for the issue: 97093

As I needed to add a test case, I also changed and unskipped the test that was skipped in: 96691🤞

before

after

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

semd · 2021-04-23T15:06:22Z

I am working on adding some test cases for this. I will open the PR when done

elasticmachine · 2021-04-27T16:04:10Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-04-27T16:04:12Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

semd · 2021-04-27T16:04:32Z

@elasticmachine merge upstream

angorayc · 2021-04-27T21:18:36Z

x-pack/plugins/security_solution/public/detections/components/rules/query_bar/index.tsx

@@ -253,7 +253,10 @@ export const QueryBarDefineRule = ({
    }
  };

-  const actionTimelineToHide = useMemo<ActionTimelineToShow[]>(() => ['duplicate'], []);
+  const actionTimelineToHide = useMemo<ActionTimelineToShow[]>(


This seems doesn't change, please consider put this as a constant and move out of the component.

const actionTimelineToHide = ['duplicate', 'createFrom'];

angorayc · 2021-04-27T21:38:38Z

...gins/security_solution/public/timelines/components/flyout/add_timeline_button/index.test.tsx

-        wrapper.find('[data-test-subj="settings-plus-in-circle"]').last().simulate('click');
-        expect(wrapper.find('[data-test-subj="create-default-btn"]').exists()).toBeTruthy();
-      });
+      wrapper.find('[data-test-subj="settings-plus-in-circle"]').last().simulate('click').update();


Thanks for fixing the tests!! Could we try putting back waitFor and just moving ...simulate(click) out of waitFor? If that works fine, let's apply this to rest of the tests in this file.

angorayc · 2021-04-27T21:39:33Z

...k/plugins/security_solution/public/timelines/components/flyout/add_timeline_button/index.tsx

@@ -47,6 +48,8 @@ const AddTimelineButtonComponent: React.FC<AddTimelineButtonComponentProps> = ({
    [onButtonClick]
  );

+  const actionTimelineToHide = useMemo<ActionTimelineToShow[]>(() => ['createFrom'], []);


We could put this as a constant and move out of the component as well.

Yes 👍
I was thinking to do so, but I followed the same way as it was in query_bar

…hub.com/semd/kibana into sergi-hide_create_template_action-97093

…_template_action-97093

angorayc

Thanks for fixing this, looks good to merge. 👍

stephmilovic

Fantastic first PR @semd! Thank you for taking the time to write thorough tests and fix flakey ones. Great work, so happy to have you on the team. LGTM! 🏁 🏎️ 🎆 🥳 🇪🇸 🥇

stephmilovic · 2021-04-28T15:54:08Z

x-pack/plugins/security_solution/public/detections/components/rules/query_bar/index.test.tsx

@@ -59,7 +59,7 @@ describe('QueryBarDefineRule', () => {
    expect(wrapper.dive().find('[data-test-subj="query-bar-define-rule"]')).toHaveLength(1);
  });

-  it('renders import query from saved timeline modal with no timeline action correctly', () => {
+  it('renders import query from saved timeline modal actions hidden correctly', () => {


hooray! thank you

kibanamachine · 2021-04-28T17:52:40Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.0MB	7.0MB	+59.0B

History

💚 Build #122953 succeeded f3c3035
💔 Build #122912 failed e4d3f63
💚 Build #122728 succeeded 588e1c8
💚 Build #122620 succeeded 38d486c
💚 Build #122062 succeeded 006c81b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

stephmilovic · 2021-04-28T21:01:25Z

let me know if you need help with the backport PRs! you should kick them off as soon as you merge this

…astic#98144) * added createFrom in action to hide * prettier configured * tests to check timeline modal table actions * test changes and contant extract * removed unused dependency * prevent adding empty column to timeline table when no action need * test updated Co-authored-by: Kibana Machine <[email protected]>

…8144) (#98713) * added createFrom in action to hide * prettier configured * tests to check timeline modal table actions * test changes and contant extract * removed unused dependency * prevent adding empty column to timeline table when no action need * test updated Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

…8144) (#98714) * added createFrom in action to hide * prettier configured * tests to check timeline modal table actions * test changes and contant extract * removed unused dependency * prevent adding empty column to timeline table when no action need * test updated Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

semd added 2 commits April 23, 2021 15:57

added createFrom in action to hide

3230b6a

prettier configured

006c81b

semd requested review from angorayc and XavierM April 23, 2021 15:05

semd added bug Fixes for quality problems that affect the customer experience v7.13.0 v7.14.0 v8.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team labels Apr 26, 2021

semd changed the title ~~added createFrom in action to hide~~ [Security Solutions][Timeline] Added createFrom in action to hide Apr 26, 2021

cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Apr 26, 2021

semd self-assigned this Apr 26, 2021

tests to check timeline modal table actions

38d486c

semd linked an issue Apr 27, 2021 that may be closed by this pull request

[Security Solution] Navigation is not working for "create a template from timeline" icon under the "Import query from saved timeline" when creating a custom rule. #97093

Closed

semd marked this pull request as ready for review April 27, 2021 16:04

semd requested a review from a team as a code owner April 27, 2021 16:04

Merge branch 'master' into sergi-hide_create_template_action-97093

588e1c8

angorayc reviewed Apr 27, 2021

View reviewed changes

semd added 4 commits April 28, 2021 11:41

test changes and contant extract

854faab

Merge branch 'sergi-hide_create_template_action-97093' of https://git…

e4d3f63

…hub.com/semd/kibana into sergi-hide_create_template_action-97093

removed unused dependency

ed6e0a3

Merge remote-tracking branch 'upstream/master' into sergi-hide_create…

f3c3035

…_template_action-97093

angorayc approved these changes Apr 28, 2021

View reviewed changes

semd added 2 commits April 28, 2021 17:38

prevent adding empty column to timeline table when no action need

19bf8f4

test updated

99ec69f

stephmilovic approved these changes Apr 28, 2021

View reviewed changes

semd merged commit 3f48479 into elastic:master Apr 29, 2021

semd mentioned this pull request Apr 29, 2021

[7.x] [Security Solutions][Timeline] Added createFrom in action to hide (#98144) #98713

Merged

semd mentioned this pull request Apr 29, 2021

[7.13] [Security Solutions][Timeline] Added createFrom in action to hide (#98144) #98714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solutions][Timeline] Added createFrom in action to hide #98144

[Security Solutions][Timeline] Added createFrom in action to hide #98144

semd commented Apr 23, 2021 •

edited

Loading

semd commented Apr 23, 2021

elasticmachine commented Apr 27, 2021

elasticmachine commented Apr 27, 2021

semd commented Apr 27, 2021

angorayc Apr 27, 2021 •

edited

Loading

angorayc Apr 27, 2021 •

edited

Loading

angorayc Apr 27, 2021

semd Apr 28, 2021

angorayc left a comment

stephmilovic left a comment

stephmilovic Apr 28, 2021

kibanamachine commented Apr 28, 2021

stephmilovic commented Apr 28, 2021 •

edited

Loading

[Security Solutions][Timeline] Added createFrom in action to hide #98144

[Security Solutions][Timeline] Added createFrom in action to hide #98144

Conversation

semd commented Apr 23, 2021 • edited Loading

Summary

Checklist

semd commented Apr 23, 2021

elasticmachine commented Apr 27, 2021

elasticmachine commented Apr 27, 2021

semd commented Apr 27, 2021

angorayc Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

angorayc Apr 27, 2021 • edited Loading

Choose a reason for hiding this comment

angorayc Apr 27, 2021

Choose a reason for hiding this comment

semd Apr 28, 2021

Choose a reason for hiding this comment

angorayc left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

stephmilovic Apr 28, 2021

Choose a reason for hiding this comment

kibanamachine commented Apr 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

stephmilovic commented Apr 28, 2021 • edited Loading

semd commented Apr 23, 2021 •

edited

Loading

angorayc Apr 27, 2021 •

edited

Loading

angorayc Apr 27, 2021 •

edited

Loading

stephmilovic commented Apr 28, 2021 •

edited

Loading