[Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert #96633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empting to create a Tracking Containment alert
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
mattkime
approved these changes
Apr 8, 2021
…ervice to add saved object to cache when index pattern is created
nreese
commented
Apr 8, 2021
| @@ -535,6 +535,7 @@ export class IndexPatternsService { | |||
| }); | |||
| indexPattern.id = response.id; | |||
| this.indexPatternCache.set(indexPattern.id, Promise.resolve(indexPattern)); | |||
| this.savedObjectsCache.push(response); | |||
There was a problem hiding this comment.
@mattkime Mind taking a look at this change. I was running into a problem where uploading a file in maps, https://www.elastic.co/guide/en/kibana/7.x/import-geospatial-data.html, resulted in getIdsAndTitles not containing the new index pattern. Instead of forcing IndexPatternSelect to call getIdsAndTitles with a force refresh, lets just update the cache when an index pattern is added
thomasneirynck
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
thx. I tested in alerting and maps and works as expected.
Thanks for creating #96644 as follow-up. That's a really interesting approach; fixing the problem by punting on the issue altogether.
kindsun
reviewed
Apr 8, 2021
src/plugins/data/public/ui/index_pattern_select/index_pattern_select.tsx
Show resolved
Hide resolved
kindsun
approved these changes
Apr 8, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 9, 2021
…empting to create a Tracking Containment alert (elastic#96633) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <[email protected]>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 9, 2021
…empting to create a Tracking Containment alert (elastic#96633) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md
nreese
added a commit
that referenced
this pull request
Apr 9, 2021
…empting to create a Tracking Containment alert (#96633) (#96682) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchbar.md
nreese
added a commit
that referenced
this pull request
Apr 9, 2021
…empting to create a Tracking Containment alert (#96633) (#96681) * [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert * tslint * instead of forcing refresh on getIdsAndTitles, update index pattern service to add saved object to cache when index pattern is created * simplify title check * revert unneeded changes * tslint * api doc updates * fix functional test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 12, 2021
…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95418
This PR switches the implementation of IndexPatternSelect from using indexPatternService.find to instead using a combination of indexPatternService.getIdsWithTitle and indexPatternService.get. This was suggested by @mattkime to avoid using indexPatternService.find with a really large page size.