[Partial Results] Move inspector adapter integration into search source #96241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
Team:AppServices
v7.13.0
v8.0.0
auto-backport
14 tasks
added 2 commits
April 6, 2021 11:29
…tor-integration-in-search-source
…tor-integration-in-search-source
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
ppisljar
reviewed
Apr 7, 2021
| const response$ = await requestSearchSource.fetch$({ | ||
| abortSignal, | ||
| sessionId: searchSessionId, | ||
| requestResponder, |
There was a problem hiding this comment.
i think it makes sense here to pass inspectorAdapters.requests in, as we'll need that to construct the other bucket inside searchsource as well. i'm fine with leaving it as is for now however as we plan to move the other bucket code inside searchsource in a followup pr.
There was a problem hiding this comment.
I agree and I intend to make that change in the other bucket PR
lizozom
added
release_note:skip
lizozom
changed the title
9 tasks
majagrubic
approved these changes
Apr 8, 2021
| async getSearchRequestBody() { | ||
| const searchRequest = await this.flatten(); | ||
| return searchRequest.body; | ||
| getSearchRequestBody() { |
There was a problem hiding this comment.
Why is this not async any more?
There was a problem hiding this comment.
flatten was never async, this is just ceanup
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…tor-integration-in-search-source
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @lizozom |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 9, 2021
…ce (elastic#96241) * Move inspector adapter integration into search source * docs and ts Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 9, 2021
…ce (#96241) (#96701) * Move inspector adapter integration into search source * docs and ts Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Liza Katz <[email protected]>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 12, 2021
…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially resolves #83652
Release Note
Checklist
Delete any items that are not applicable to this PR.
For maintainers