console: clean up styles for entry and server code #9646
Conversation
epixa
added
Team:Operations
| @@ -150,14 +150,14 @@ module.exports = function (kibana) { | |||
| path: '/api/console/api_server', | |||
| method: ['GET', 'POST'], | |||
| handler: function (req, reply) { | |||
| let server = require('./api_server/server'); | |||
| let { sense_version, apis } = req.query; | |||
| const server = require('./api_server/server'); | |||
There was a problem hiding this comment.
Any reason not to import this at the top of the file?
| strict: off | ||
| wrap-iife: off | ||
| no-var: off | ||
| prefer-const: off |
There was a problem hiding this comment.
When will we remove these linting rules and defer to the ones in the root?
There was a problem hiding this comment.
Just like the console-root eslintrc that is deleted in this PR, we can delete the specific lint configs once we've updated the code in those directories (public and api_server).
There was a problem hiding this comment.
Sounds good. Can we track these tasks in a linting meta-issue? Unless you're planning to move on them immediately, I'm afraid that we'll lose sight of them.
There was a problem hiding this comment.
The linked issue is the issue for tracking this, but I've added the meta label to it and added four todo items, two of which are tackled here.
epixa
force-pushed
the
9603-console-linting
branch
from
59dfbed to
522acae
Compare
|
I removed that |
| @@ -150,14 +151,13 @@ module.exports = function (kibana) { | |||
| path: '/api/console/api_server', | |||
| method: ['GET', 'POST'], | |||
| handler: function (req, reply) { | |||
| let server = require('./api_server/server'); | |||
| let { sense_version, apis } = req.query; | |||
| const { senseVersion, apis } = req.query; | |||
There was a problem hiding this comment.
Originally we expected sense_version in the response, but now we're expecting senseVersion. Do we need to update any server-side code to make a corresponding change?
There was a problem hiding this comment.
I'm going to change it back since it's pulled from the request.
To be honest, I'm surprised this change worked at all, so I suspect there's some unused code/behaviors here. In any case, that's beyond the scope of this change, so I'd prefer to keep this to purely internal changes.
There was a problem hiding this comment.
Reverted it back to sense_version
Much of the code in console is original from when the project was a separate plugin and was not updated when it was ported over. Now, any code in the root of the project or in the server directory will be linted based on the global rules in Kibana.
epixa
force-pushed
the
9603-console-linting
branch
from
522acae to
aa82918
Compare
|
Thanks! |
Backports PR #9646 **Commit 1:** console: clean up styles for entry and server code Much of the code in console is original from when the project was a separate plugin and was not updated when it was ported over. Now, any code in the root of the project or in the server directory will be linted based on the global rules in Kibana. * Original sha: aa82918 * Authored by Court Ewing <[email protected]> on 2016-12-26T20:02:30Z
Backports PR #9646 **Commit 1:** console: clean up styles for entry and server code Much of the code in console is original from when the project was a separate plugin and was not updated when it was ported over. Now, any code in the root of the project or in the server directory will be linted based on the global rules in Kibana. * Original sha: aa82918 * Authored by Court Ewing <[email protected]> on 2016-12-26T20:02:30Z
Much of the code in console is original from when the project was a
separate plugin and was not updated when it was ported over. Now, any
code in the root of the project or in the server directory will be
linted based on the global rules in Kibana and more closely follow our main
JS styleguide.
For #9603