Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] update to latest styleguide #9603

Closed
2 of 5 tasks
epixa opened this issue Dec 21, 2016 · 2 comments
Closed
2 of 5 tasks

[console] update to latest styleguide #9603

epixa opened this issue Dec 21, 2016 · 2 comments
Labels
chore Feature:Console Dev Tools Console Feature Feature:Dev Tools Meta Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@epixa
Copy link
Contributor

epixa commented Dec 21, 2016

The code in Console does not match our styleguide in most places since it was copied over from a different project entirely. We should update that entire plugin to reflect the coding styles and conventions of the rest of the project so that future contributions to it can be evaluated just like we would any other.

@epixa epixa added the Meta label Dec 26, 2016
@cjcenizal cjcenizal added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Jun 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@epixa
Copy link
Contributor Author

epixa commented Sep 10, 2019

I'm going to close this as I don't think we're going to bulk update the code style just for the sake of it, and a pretty large refactor of console is going to happen anyway.

@epixa epixa closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Console Dev Tools Console Feature Feature:Dev Tools Meta Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

4 participants