[XY axis] Updates the sample data to work with the default eui palette #94781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
added
Feature:XYAxis
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
changed the title
pgayvallet
approved these changes
Mar 17, 2021
kertal
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Code LGTM 👍 , tested locally in Chrome Firefox Safari, EUI color default palette is in use in the edited sample data, just noted [Logs] Unique Visitors vs. Average Bytes where it's selected but the different colors seem to selected, guess it's because using default colors would show low contrast here (tried it out):
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Mar 18, 2021
stratoula
added a commit
that referenced
this pull request
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #94067. This PR updates our XY axis sample viz in order to use the default EUI palette instead of the legacy one. I have added the palette configuration on the saved objects and I have updated the migration script to only add the kibana legacy palette configuration for the saved objects that don't contain this info.
The reason that we are doing this is because we want to drive our users towards the EUI palettes.
How to test
Install the sample datasets again and check all the XY axis visualizations (the Legacy charts advanced setting should be off). They should load with the EUI palette, for example:
Set the switch to on (enable the vislib charts). The visualizations should render with the legacy palette.
Checklist