Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix area percentage gaps with zero fitting function #94086

Merged
merged 3 commits into from
Mar 11, 2021
Merged

[Lens] Fix area percentage gaps with zero fitting function #94086

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
701e3da
:bug: Use the zero fitting function for area percentage
dej611 Mar 9, 2021
3cd9d8c
Merge branch 'master' into fix/93648-2
kibanamachine Mar 9, 2021
2e0b867
Merge branch 'master' into fix/93648-2
kibanamachine Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions x-pack/plugins/lens/public/xy_visualization/expression.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,14 @@ export function XYChart({
layersAlreadyFormatted
);

const isStacked = seriesType.includes('stacked');
const isPercentage = seriesType.includes('percentage');
const isBarChart = seriesType.includes('bar');
const enableHistogramMode =
isHistogram &&
(isStacked || !splitAccessor) &&
(isStacked || !isBarChart || !chartHasMoreThanOneBarSeries);

// For date histogram chart type, we're getting the rows that represent intervals without data.
// To not display them in the legend, they need to be filtered out.
const rows = tableConverted.rows.filter(
Expand All @@ -674,7 +682,7 @@ export function XYChart({

const seriesProps: SeriesSpec = {
splitSeriesAccessors: splitAccessor ? [splitAccessor] : [],
stackAccessors: seriesType.includes('stacked') ? [xAccessor as string] : [],
stackAccessors: isStacked ? [xAccessor as string] : [],
id: `${splitAccessor}-${accessor}`,
xAccessor: xAccessor || 'unifiedX',
yAccessors: [accessor],
Expand Down Expand Up @@ -710,13 +718,8 @@ export function XYChart({
);
},
groupId: yAxis?.groupId,
enableHistogramMode:
isHistogram &&
(seriesType.includes('stacked') || !splitAccessor) &&
(seriesType.includes('stacked') ||
!seriesType.includes('bar') ||
!chartHasMoreThanOneBarSeries),
stackMode: seriesType.includes('percentage') ? StackMode.Percentage : undefined,
enableHistogramMode,
stackMode: isPercentage ? StackMode.Percentage : undefined,
timeZone,
areaSeriesStyle: {
point: {
Expand Down Expand Up @@ -797,7 +800,11 @@ export function XYChart({
case 'area_stacked':
case 'area_percentage_stacked':
return (
<AreaSeries key={index} {...seriesProps} fit={getFitOptions(fittingFunction)} />
<AreaSeries
key={index}
{...seriesProps}
fit={isPercentage ? 'zero' : getFitOptions(fittingFunction)}
/>
);
case 'area':
return (
Expand Down