-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix area percentage gaps with zero fitting function #94086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@elasticmachine merge upstream |
Gaps will be fixed in a patched version of elastic charts with elastic/elastic-charts#1067 |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as expected
…4086) Co-authored-by: Kibana Machine <[email protected]>
…94452) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
@flash1293 and @dej611 Since this issue has likely been in past kibana releases depending on when this regression was caused in chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=1163912). What do you guys think about merging this patch fix (elastic/elastic-charts#1067) into cc: @markov00 |
It's fine for 7.12 for me cc @timroes |
Ok, merged here #94698 |
Summary
Fixes #93648
Alternative to #93812 as discussed with @nickofthyme .
I've implemented the alternative solution using the
fit="zero"
solution, but I still see some gaps in the middle of the stacked area.Between the 2021-24-02 00:00 and 12:00 there's still a gap not filled with the fitting function. I've used the
logs
sample dataset, but if the specific data is required let me know.Checklist
Delete any items that are not applicable to this PR.
For maintainers