[Lens] Fix wrong suggestions from Datatable to other visualizations #93920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
v8.0.0
Feature:Lens
v7.13.0
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dej611
changed the title
flash1293
approved these changes
Mar 8, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 9, 2021
…lastic#93920) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Mar 9, 2021
…93920) (#94096) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #93572
This PR is a proposal fix for the wrong suggestions when using
last_valueoperations in a datatable context, where the first used is ofstringtype.The proposed solution is a combination of two fixes:
last_valueI've attempted to work at the
indexpatternlevel, but this specific scenario requires quite some bit of information, which has already handled by the visualization.Each visualization knowns better what it can handle, therefore it's easier to model specific vaidation at this level: the only missing bit was the access to the column operation when validating, which has been added.
While the validation will not currently shown, as it is used as filter criteria for the suggestions, in the future it may appear if newer feature enable choosing string data fields as possible choice.
Checklist
Delete any items that are not applicable to this PR.