[Lens] Fix wrong suggestions from Datatable to other visualizations (#…

…93920) Co-authored-by: Kibana Machine <[email protected]>
elastic · Mar 9, 2021 · 8e6d4ee · 8e6d4ee
1 parent 326dfa4
commit 8e6d4ee
Show file tree

Hide file tree

Showing 5 changed files with 79 additions and 3 deletions.
diff --git a/x-pack/plugins/lens/public/editor_frame_service/editor_frame/state_helpers.ts b/x-pack/plugins/lens/public/editor_frame_service/editor_frame/state_helpers.ts
@@ -162,7 +162,7 @@ export const validateDatasourceAndVisualization = (
     : undefined;
 
   const visualizationValidationErrors = currentVisualizationState
-    ? currentVisualization?.getErrorMessages(currentVisualizationState)
+    ? currentVisualization?.getErrorMessages(currentVisualizationState, frameAPI.datasourceLayers)
     : undefined;
 
   if (datasourceValidationErrors?.length || visualizationValidationErrors?.length) {

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx
@@ -105,6 +105,7 @@ export const lastValueOperation: OperationDefinition<LastValueIndexPatternColumn
       label: ofName(field.displayName),
       sourceField: field.name,
       params: newParams,
+      scale: field.type === 'string' ? 'ordinal' : 'ratio',
     };
   },
   getPossibleOperationForField: ({ aggregationRestrictions, type }) => {

diff --git a/x-pack/plugins/lens/public/types.ts b/x-pack/plugins/lens/public/types.ts
@@ -636,7 +636,10 @@ export interface Visualization<T = unknown> {
    * The frame will call this function on all visualizations at few stages (pre-build/build error) in order
    * to provide more context to the error and show it to the user
    */
-  getErrorMessages: (state: T) => Array<{ shortMessage: string; longMessage: string }> | undefined;
+  getErrorMessages: (
+    state: T,
+    datasourceLayers?: Record<string, DatasourcePublicAPI>
+  ) => Array<{ shortMessage: string; longMessage: string }> | undefined;
 
   /**
    * The frame calls this function to display warnings about visualization

diff --git a/x-pack/plugins/lens/public/xy_visualization/visualization.test.ts b/x-pack/plugins/lens/public/xy_visualization/visualization.test.ts
@@ -587,6 +587,23 @@ describe('xy_visualization', () => {
   });
 
   describe('#getErrorMessages', () => {
+    let mockDatasource: ReturnType<typeof createMockDatasource>;
+    let frame: ReturnType<typeof createMockFramePublicAPI>;
+
+    beforeEach(() => {
+      frame = createMockFramePublicAPI();
+      mockDatasource = createMockDatasource('testDatasource');
+
+      mockDatasource.publicAPIMock.getOperationForColumnId.mockReturnValue({
+        dataType: 'string',
+        label: 'MyOperation',
+      } as Operation);
+
+      frame.datasourceLayers = {
+        first: mockDatasource.publicAPIMock,
+      };
+    });
+
     it("should not return an error when there's only one dimension (X or Y)", () => {
       expect(
         xyVisualization.getErrorMessages({
@@ -775,6 +792,32 @@ describe('xy_visualization', () => {
         },
       ]);
     });
+
+    it('should return an error when accessor type is of the wrong type', () => {
+      expect(
+        xyVisualization.getErrorMessages(
+          {
+            ...exampleState(),
+            layers: [
+              {
+                layerId: 'first',
+                seriesType: 'area',
+                splitAccessor: 'd',
+                xAccessor: 'a',
+                accessors: ['b'], // just use a single accessor to avoid too much noise
+              },
+            ],
+          },
+          frame.datasourceLayers
+        )
+      ).toEqual([
+        {
+          shortMessage: 'Wrong data type for Vertical axis.',
+          longMessage:
+            'The dimension MyOperation provided for the Vertical axis has the wrong data type. Expected number but have string',
+        },
+      ]);
+    });
   });
 
   describe('#getWarningMessages', () => {

diff --git a/x-pack/plugins/lens/public/xy_visualization/visualization.tsx b/x-pack/plugins/lens/public/xy_visualization/visualization.tsx
@@ -340,7 +340,7 @@ export const getXyVisualization = ({
     toExpression(state, layers, paletteService, attributes),
   toPreviewExpression: (state, layers) => toPreviewExpression(state, layers, paletteService),
 
-  getErrorMessages(state) {
+  getErrorMessages(state, datasourceLayers) {
     // Data error handling below here
     const hasNoAccessors = ({ accessors }: XYLayerConfig) =>
       accessors == null || accessors.length === 0;
@@ -373,6 +373,35 @@ export const getXyVisualization = ({
       }
     }
 
+    if (datasourceLayers && state) {
+      for (const layer of state.layers) {
+        const datasourceAPI = datasourceLayers[layer.layerId];
+        if (datasourceAPI) {
+          for (const accessor of layer.accessors) {
+            const operation = datasourceAPI.getOperationForColumnId(accessor);
+            if (operation && operation.dataType !== 'number') {
+              errors.push({
+                shortMessage: i18n.translate('xpack.lens.xyVisualization.dataTypeFailureYShort', {
+                  defaultMessage: `Wrong data type for {axis}.`,
+                  values: {
+                    axis: getAxisName('y', { isHorizontal: isHorizontalChart(state.layers) }),
+                  },
+                }),
+                longMessage: i18n.translate('xpack.lens.xyVisualization.dataTypeFailureYLong', {
+                  defaultMessage: `The dimension {label} provided for the {axis} has the wrong data type. Expected number but have {dataType}`,
+                  values: {
+                    label: operation.label,
+                    dataType: operation.dataType,
+                    axis: getAxisName('y', { isHorizontal: isHorizontalChart(state.layers) }),
+                  },
+                }),
+              });
+            }
+          }
+        }
+      }
+    }
+
     return errors.length ? errors : undefined;
   },