-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] transactions.kubernetes.pod
can be undefined
#90044
Conversation
Pinging @elastic/apm-ui (Team:apm) |
Q: Should the label point to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for fixing this @afharo ! I'm surprised this can even happen. We have a contract test between apm-server and kibana to ensure it doesn't. But we should test it against the minimal doc: |
Created this follow-up issue: #90065 |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
# Conflicts: # x-pack/plugins/apm/typings/es_schemas/raw/fields/kubernetes.ts
Summary
We've been notified about some errors where the transaction view doesn't load because the
transactions.kubernetes
payload looks like this:This PR makes
kubernetes.pod
an optional parameter in the Types definitions to make sure every logic validates it exists before reaching to its internal properties.Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release Notes
Fixes issue that may show empty Transaction page in the APM app.