Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Improve contract test with APM Server #90065

Closed
sorenlouv opened this issue Feb 2, 2021 · 1 comment
Closed

[APM] Improve contract test with APM Server #90065

sorenlouv opened this issue Feb 2, 2021 · 1 comment
Labels
apm:needs-test Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@sorenlouv
Copy link
Member

Related to #90044

We have a contract test between apm-server and kibana but it doesn't catch properties that are typed as "required" but are only "optional". We test transactions here:

https://github.com/elastic/apm-integration-testing/blob/12b688db3b4f5166433532ccc53fbcad80147c77/scripts/kibana/validate-ts-interfaces-against-apm-server-sample-docs/scripts/download-sample-docs.ts#L23-L27

We should add an additional test that verifies our schema against the minimal doc:
https://github.com/elastic/apm-server/blob/master/beater/test_approved_es_documents/TestPublishIntegrationMinimalEvents.approved.json
@sorenlouv sorenlouv added [zube]: Inbox Team:APM All issues that need APM UI Team support labels Feb 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv mentioned this issue Feb 2, 2021
Merged
9 tasks
@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture and removed technical-debt labels Feb 3, 2021
@sorenlouv sorenlouv closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:needs-test Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sorenlouv @jen-huang @gbamparop @elasticmachine