Remove extra external link in markdown editor #86933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2020 14:38
sulemanof
added
Feature:Markdown
|
Good catch @sulemanof 🙂 |
stratoula
reviewed
Dec 24, 2020
| const props = ({ | ||
| stateParams: { | ||
| fontSize: 12, | ||
| markdown: 'hello from 2020 🥳', |
stratoula
reviewed
Dec 24, 2020
|
|
||
| it('should update markdown on change', () => { | ||
| const comp = shallow(<MarkdownOptions {...props} />); | ||
| const value = 'see you in 2021 😎'; |
stratoula
approved these changes
Dec 24, 2020
|
@elasticmachine merge upstream |
poffdeluxe
approved these changes
Jan 4, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 5, 2021
* Remove extra external icon * Add unit tests Co-authored-by: Kibana Machine <[email protected]>
This was referenced Jan 5, 2021
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 5, 2021
* Remove extra external icon * Add unit tests Co-authored-by: Kibana Machine <[email protected]>
stratoula
added a commit
that referenced
this pull request
Jan 5, 2021
* Remove extra external icon * Add unit tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Daniil <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
stratoula
added a commit
that referenced
this pull request
Jan 5, 2021
* Remove extra external icon * Add unit tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Daniil <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here is the issue in the markdown editor with an extra external icon rendered next to
Helptext ->The reason of the regression is an addition in eui - it adds the icon for external links by default now elastic/eui#4172
Fix:
Checklist
Delete any items that are not applicable to this PR.
For maintainers