Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 'opens in new target' text for links for screen readers #4172

Merged
merged 7 commits into from
Oct 29, 2020
Merged

Adds 'opens in new target' text for links for screen readers #4172

merged 7 commits into from
Oct 29, 2020

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented Oct 22, 2020 •
edited
Loading

Summary

Fixes #3659 if we decide to merge

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@myasonik myasonik mentioned this pull request Oct 22, 2020
Closed
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4172/

chandlerprall
chandlerprall suggested changes Oct 27, 2020
View reviewed changes
src/components/link/link.tsx Outdated Show resolved Hide resolved
@chandlerprall chandlerprall marked this pull request as ready for review October 28, 2020 17:11
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4172/

cchaos
cchaos suggested changes Oct 28, 2020
View reviewed changes
src/components/link/link.tsx Outdated Show resolved Hide resolved
src/components/link/link.tsx Outdated Show resolved Hide resolved
src-docs/src/views/link/link.js Outdated Show resolved Hide resolved
src-docs/src/views/link/link.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src-docs/src/views/link/link.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4172/

Michail Yasonik and others added 2 commits October 28, 2020 15:29
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4172/

@myasonik myasonik requested a review from cchaos October 28, 2020 20:44
@cchaos
Copy link
Contributor

cchaos commented Oct 28, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4172/

cchaos
cchaos approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@myasonik myasonik merged commit 17984d3 into elastic:master Oct 29, 2020
@myasonik myasonik deleted the open-in-new-target branch October 29, 2020 13:44
cchaos added a commit to andreadelrio/eui that referenced this pull request Nov 4, 2020
@cchaos
Adds 'opens in new target' text for links for screen readers (elastic…
e6367ae 
…#4172)

Co-authored-by: Caroline Horn <[email protected]>
@thompsongl thompsongl mentioned this pull request Nov 5, 2020
Merged
@sulemanof sulemanof mentioned this pull request Dec 24, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiLink] Adding new tab/window help text for screen readers
4 participants
@myasonik @kibanamachine @cchaos @chandlerprall