[CI] Combines Jest test jobs #85850

tylersmalley · 2020-12-14T20:13:46Z

Based on #84848

Combines the OSS and X-Pack Jest tests into a single job.
Stores code coverage JSON in CI
Removes jest.config.js from the x-pack directory.

elasticmachine · 2020-12-23T07:05:38Z

Pinging @elastic/kibana-operations (Team:Operations)

tylersmalley · 2020-12-23T17:40:37Z

@dmlemeshko, you mind looking over this. In addition to combining the OSS/X-Pack Jest jobs, I am also outputting coverage.

jbudz

Looks like it got stuck on the integration tests

01:50:38  Jest did not exit one second after the test run has completed.
01:50:38  
01:50:38  This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.
03:40:47  Sending interrupt signal to process

https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/96117/execution/node/411/

Code changes LGTM

dmlemeshko · 2020-12-23T18:37:58Z

jest.config.integration.js

@@ -36,4 +36,5 @@ module.exports = {
    ],
  ],
  setupFilesAfterEnv: ['<rootDir>/packages/kbn-test/target/jest/setup/after_env.integration.js'],
+  coverageDirectory: '<rootDir>/target/jest-coverage/jest_integration',


We need to copy json file from this path into the temp directory next to the other jest coverage json before merging: nyc does not support glob patterns or list of folders, so our config uses
a single folder with jest oss, xpack and integration coverage json files

Probably it can added in src/dev/code_coverage/shell_scripts/merge_jest_and_functional.sh :

cp -r tmp/extracted_coverage/target/kibana-coverage/jest_integration/json-summary.json target/kibana-coverage/jest/integration-json-summary.json

I also just changing path to <rootDir>/target/kibana-coverage/jest_integration to follow the same pattern /target/kibana-coverage/**

dmlemeshko · 2020-12-23T18:55:19Z

I started coverage job https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/166/ but guess it won't be correct since jest integration results are not in the right place

tylersmalley · 2020-12-23T21:13:24Z

@dmlemeshko, thanks for taking a look. I pushed 50707860590136a92ff7f466f73aa840444fcc1e, which uses unique file names instead of directories and kicked off another job at https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/167/

I had to go back to defining the reporter in code based on an environment variable as it doesn't appear to you pass the necessary nested array configuration through the Jest CLI.

target
├── coverage
│   ├── jest-integration.json
│   └── jest.json
└── junit
    ├── TEST-Jest Integration Tests.xml
    └── TEST-Jest Tests.xml

tylersmalley · 2021-01-14T17:55:45Z

For my reference, here is the QA code coverage job: https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/179/

tylersmalley · 2021-01-14T21:00:36Z

@dmlemeshko, mind taking a look at this again to see if the changes keep your code coverage reports intact?

Signed-off-by: Tyler Smalley <[email protected]>

kibanamachine · 2021-01-27T08:18:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5751b50

Metrics [docs]

✅ unchanged

History

💔 Build #101353 failed c58f51756234aa8341193b693d071aad1d65a063
💚 Build #101327 succeeded 2862d6864a467895fac3003e9d751a8f3980ad76
💔 Build #101305 failed c33d7b3968efe7499926f14df96c21f7167e9c96
💔 Build #101285 failed 4e4579d6d13c3874ae721eb952c633d930357936
💔 Build #101261 failed d178534735fcc904feeeb63e2b8416c57325d399

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tylersmalley · 2021-01-27T15:33:24Z

TeamCity job passing: https://ci.elastic.co/buildConfiguration/Kibana_master_Pull_Request/58521

Signed-off-by: Tyler Smalley <[email protected]> # Conflicts: # jest.config.oss.js # src/dev/code_coverage/shell_scripts/extract_archives.sh # test/scripts/jenkins_unit.sh # test/scripts/jenkins_xpack.sh # vars/kibanaCoverage.groovy # x-pack/jest.config.js

…y-tests * 'master' of github.com:elastic/kibana: (276 commits) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) skip flaky suite (elastic#89379) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/test/accessibility/config.ts

…ana into task-manager/shift-on-trend * 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits) [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) ...

* [CI] Combines Jest test jobs (#85850) Signed-off-by: Tyler Smalley <[email protected]> # Conflicts: # jest.config.oss.js # src/dev/code_coverage/shell_scripts/extract_archives.sh # test/scripts/jenkins_unit.sh # test/scripts/jenkins_xpack.sh # vars/kibanaCoverage.groovy # x-pack/jest.config.js * [CI] Decrease number of Jest workers Signed-off-by: Tyler Smalley <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

This reverts commit 46ac4ed.

This reverts commit e36dfcd.

tylersmalley force-pushed the jest-single branch 7 times, most recently from 0f4b877 to 7adf829 Compare December 18, 2020 00:53

tylersmalley force-pushed the jest-single branch 2 times, most recently from 9b39e9f to 1c8d6de Compare December 22, 2020 00:00

tylersmalley changed the title ~~WIP: Test combining Jest tests~~ [CI] Combines Jest tests Dec 22, 2020

tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.12.0 v8.0.0 labels Dec 23, 2020

tylersmalley force-pushed the jest-single branch from 1c8d6de to 9c44d09 Compare December 23, 2020 07:05

tylersmalley marked this pull request as ready for review December 23, 2020 07:05

tylersmalley requested a review from a team as a code owner December 23, 2020 07:05

tylersmalley requested a review from dmlemeshko December 23, 2020 17:39

jbudz reviewed Dec 23, 2020

View reviewed changes

dmlemeshko reviewed Dec 23, 2020

View reviewed changes

tylersmalley changed the title ~~[CI] Combines Jest tests~~ [CI] Combines Jest test jobs Dec 23, 2020

tylersmalley force-pushed the jest-single branch 2 times, most recently from 9962470 to fc2a1bd Compare January 14, 2021 00:03

tylersmalley requested a review from a team as a code owner January 14, 2021 23:28

elastic deleted a comment from kibanamachine Jan 26, 2021

elastic deleted a comment from dmlemeshko Jan 26, 2021

tylersmalley force-pushed the jest-single branch 7 times, most recently from 69bb172 to c58f517 Compare January 27, 2021 05:29

Tyler Smalley added 9 commits January 26, 2021 22:34

Combines Jest unit tests

6fbf757

Signed-off-by: Tyler Smalley <[email protected]>

Unique coverage file names

837dc40

Signed-off-by: Tyler Smalley <[email protected]>

Removes logHeapUsage

5b1bbea

Signed-off-by: Tyler Smalley <[email protected]>

Removes jest.config.js in x-pack root

6f58359

Signed-off-by: Tyler Smalley <[email protected]>

Lower maxWorkers

baac8c6

Signed-off-by: Tyler Smalley <[email protected]>

Updates upload pattern

7324051

Signed-off-by: Tyler Smalley <[email protected]>

Code Coverage cleanup

962fe9d

Signed-off-by: Tyler Smalley <[email protected]>

Increase workers

1b976eb

Signed-off-by: Tyler Smalley <[email protected]>

Transition for TeamCity

5751b50

Signed-off-by: Tyler Smalley <[email protected]>

tylersmalley force-pushed the jest-single branch from c58f517 to 5751b50 Compare January 27, 2021 06:34

tylersmalley merged commit 46ac4ed into elastic:master Jan 27, 2021

tylersmalley mentioned this pull request Jan 27, 2021

[7.x] [CI] Combines Jest test jobs (#85850) #89432

Merged

jbudz added a commit that referenced this pull request Jan 28, 2021

Revert "[CI] Combines Jest test jobs (#85850)"

5c709bb

This reverts commit 46ac4ed.

jbudz added a commit that referenced this pull request Jan 28, 2021

Revert "[7.x] [CI] Combines Jest test jobs (#85850) (#89432)"

c2163a5

This reverts commit e36dfcd.

tylersmalley mentioned this pull request Feb 9, 2021

[CI] Combines Jest unit tests #89948

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Combines Jest test jobs #85850

[CI] Combines Jest test jobs #85850

tylersmalley commented Dec 14, 2020 •

edited

Loading

elasticmachine commented Dec 23, 2020

tylersmalley commented Dec 23, 2020

jbudz left a comment

dmlemeshko Dec 23, 2020

dmlemeshko Dec 23, 2020

dmlemeshko Dec 23, 2020

dmlemeshko commented Dec 23, 2020

tylersmalley commented Dec 23, 2020

tylersmalley commented Jan 14, 2021 •

edited

Loading

tylersmalley commented Jan 14, 2021

kibanamachine commented Jan 27, 2021

tylersmalley commented Jan 27, 2021

[CI] Combines Jest test jobs #85850

[CI] Combines Jest test jobs #85850

Conversation

tylersmalley commented Dec 14, 2020 • edited Loading

elasticmachine commented Dec 23, 2020

tylersmalley commented Dec 23, 2020

jbudz left a comment

Choose a reason for hiding this comment

dmlemeshko Dec 23, 2020

Choose a reason for hiding this comment

dmlemeshko Dec 23, 2020

Choose a reason for hiding this comment

dmlemeshko Dec 23, 2020

Choose a reason for hiding this comment

dmlemeshko commented Dec 23, 2020

tylersmalley commented Dec 23, 2020

tylersmalley commented Jan 14, 2021 • edited Loading

tylersmalley commented Jan 14, 2021

kibanamachine commented Jan 27, 2021

💚 Build Succeeded

Metrics [docs]

History

tylersmalley commented Jan 27, 2021

tylersmalley commented Dec 14, 2020 •

edited

Loading

tylersmalley commented Jan 14, 2021 •

edited

Loading