[Fleet] Allow to send SETTINGS action #83707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
commented
Nov 18, 2020
| ]), | ||
| data: schema.maybe(schema.any()), | ||
| ack_data: schema.maybe(schema.any()), | ||
| sent_at: schema.maybe(schema.string()), |
There was a problem hiding this comment.
I removed sent_at and ack_data as there is no need for them when creating an action
There was a problem hiding this comment.
should we change saved object definition and add migrations to match?
There was a problem hiding this comment.
it's required in the saved_object we update that when the agent acknowledge an action, but it's not on a new action
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
i will send |
|
@michalpristas Yes I will create a PR to show the |
6 tasks
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Nov 20, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 20, 2020
* master: (38 commits) [ML] Data frame analytics: Adds functionality to map view (elastic#83710) Add usage collection for savedObject tagging (elastic#83160) [SECURITY_SOLUTION] 145: Advanced Policy Tests (elastic#82898) [APM] Service overview transactions table (elastic#83429) [ML] Fix Single Metric Viewer not loading if job is metric with no partition (elastic#83880) do not export types from 3rd party modules as 'type' (elastic#83803) [Fleet] Allow to send SETTINGS action (elastic#83707) Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Alert Details Alert Instances renders the active alert instances (elastic#83478) [Uptime]Reduce chart height on monitor detail page (elastic#83777) [APM] Prefer `APIReturnType` over `PromiseReturnType` (elastic#83843) [Observability] Fix telemetry for Observability Overview (elastic#83847) [Alerting] Adds generic UI for the definition of conditions for Action Groups (elastic#83278) ensure workload agg doesnt run until next interval when it fails (elastic#83632) [ILM] Policy form should not throw away data (elastic#83077) [Monitoring] Stop collecting Kibana Usage in bulkUploader (elastic#83546) [TSVB] fix wrong imports (elastic#83798) [APM] Correlations UI POC (elastic#82256) list all the refs in tsconfig.json (elastic#83678) Bump jest (and related packages) to v26.6.3 (elastic#83724) Functional tests - stabilize reporting tests for cloud execution (elastic#83787) ...
nchaulet
added a commit
that referenced
this pull request
Nov 20, 2020
12 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially resolve #83330
To be able to dynamically set the log level of an agent, we need to send a new action to the agent with that
log_levelThis pull request update the actions endpoint to be able to send that new
SETTINGSaction.Note action will exists in Fleet Server so there is no issue of adding a new one.
Tests
I added an API integration test to ensure we can create that action.
If you want to test it manually you can enroll an agent, checkin, create a SETTINGS action, then checkin again you will have the action.
curl --request POST \ --url http://localhost:5601/api/ingest_manager/fleet/agents/{AGENT_ID}/actions \ --header 'Authorization: Basic ZWxhc3RpYzpjaGFuZ2VtZQ==' \ --header 'Content-Type: application/json' \ --header 'kbn-xsrf: as' \ --data '{ "action": { "type": "SETTINGS", "data": { "log_level": "debug" } } }'cc @michalpristas