[Ingest Manager] Log level reloadable from fleet #22690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
michalpristas
changed the title
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
approved these changes
Nov 20, 2020
| @@ -26,8 +26,11 @@ const agentInfoKey = "agent" | |||
| // defaultAgentActionStoreFile is the file that will contains the action that can be replayed after restart. | |||
| const defaultAgentActionStoreFile = "action_store.yml" | |||
|
|
|||
| const defaultLogLevel = "debug" | |||
There was a problem hiding this comment.
With this change can we move the default up to info?
Debug level is still causing duplicate events, which still needs to be solved even in debug.
| zapLevel = zapcore.ErrorLevel | ||
| } | ||
|
|
||
| return zapLevel |
There was a problem hiding this comment.
Isn't there something that already does this in libbeat? Couldn't we change that to expose it, instead of implementing it here.
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Nov 24, 2020
[Ingest Manager] Log level reloadable from fleet (elastic#22690)
6 tasks
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Nov 26, 2020
[Ingest Manager] Log level reloadable from fleet (elastic#22690)
michalpristas
added a commit
that referenced
this pull request
Dec 1, 2020
blakerouse
pushed a commit
that referenced
this pull request
Dec 14, 2020
* [Ingest Manager] Log level reloadable from fleet (#22690) [Ingest Manager] Log level reloadable from fleet (#22690) * aa * create drop * updated drop * process contains everything * drop start time * undo exposed endpoint * sanitize dataset name * ups * agent expose http * collect all metrics from beats * colelct all from beats * golint * cleaner docs * updated structure * cgroup * long live file saving issues
blakerouse
pushed a commit
to blakerouse/beats
that referenced
this pull request
Dec 14, 2020
* [Ingest Manager] Log level reloadable from fleet (elastic#22690) [Ingest Manager] Log level reloadable from fleet (elastic#22690) * aa * create drop * updated drop * process contains everything * drop start time * undo exposed endpoint * sanitize dataset name * ups * agent expose http * collect all metrics from beats * colelct all from beats * golint * cleaner docs * updated structure * cgroup * long live file saving issues (cherry picked from commit 49c8d87)
blakerouse
added a commit
that referenced
this pull request
Dec 14, 2020
…23105) * [Ingest Management] Agent expose metrics (#22793) * [Ingest Manager] Log level reloadable from fleet (#22690) [Ingest Manager] Log level reloadable from fleet (#22690) * aa * create drop * updated drop * process contains everything * drop start time * undo exposed endpoint * sanitize dataset name * ups * agent expose http * collect all metrics from beats * colelct all from beats * golint * cleaner docs * updated structure * cgroup * long live file saving issues (cherry picked from commit 49c8d87) * Add changelog. Co-authored-by: Michal Pristas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces log level reloading initiated by SETTINGS action coming from fleet introduced in this PR: elastic/kibana#83707
This strategy reexecs agent on log level change.
Why is it important?
#20756
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.