Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add basic license test run details to ML+Transform READMEs #83259

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 12, 2020

Summary

This PR updates the READMEs of the ml and transform plugins to include instructions how to run basic license tests.

@pheyos pheyos added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs v7.11.0 labels Nov 12, 2020
@pheyos pheyos requested a review from a team as a code owner November 12, 2020 09:12
@pheyos pheyos self-assigned this Nov 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these changes!
It looks like our documentation is not consistent, but the style guide indicates license types should be capitalized (Trial, Basic): https://brand.elastic.co/302f66895/p/194a3b-writing-style-guide (under subscription).

@pheyos
Copy link
Member Author

pheyos commented Nov 16, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 406a568 into elastic:master Nov 16, 2020
@pheyos pheyos deleted the add_basic_license_tests_to_readme branch November 16, 2020 09:25
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 16, 2020
…tic#83259)

This PR updates the READMEs of the ml and transform plugins to include instructions how to run basic license tests.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 16, 2020
* master:
  Migrate `/translations` route to core (elastic#83280)
  [APM] Ensure APM jest script can run (elastic#83398)
  [Uptime] Monitor status alert use url as instance (elastic#81736)
  [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259)
  TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964)
  [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139)
  Skips Vega test
  skip flaky suite (elastic#79967)
  [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020)
  Added ability to fire actions when an alert instance is resolved (elastic#82799)
  [ML] Adds functional tests for the index data visualizer card contents (elastic#83174)
pheyos added a commit that referenced this pull request Nov 16, 2020
…) (#83400)

This PR updates the READMEs of the ml and transform plugins to include instructions how to run basic license tests.
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 16, 2020
… into add-logs-to-node-details

* 'add-logs-to-node-details' of github.com:phillipb/kibana:
  fix tall vislib charts in visualize (elastic#83340)
  [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957)
  [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401)
  fix logstash central pipeline management test  (elastic#83281)
  [Search] Send to background UI (elastic#81793)
  Migrate `/translations` route to core (elastic#83280)
  [APM] Ensure APM jest script can run (elastic#83398)
  [Uptime] Monitor status alert use url as instance (elastic#81736)
  [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259)
  TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964)
  [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139)
  Skips Vega test
  skip flaky suite (elastic#79967)
  [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020)
  Added ability to fire actions when an alert instance is resolved (elastic#82799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs :ml release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants