[bundle optimization] Update to semver 7.x to get tree-shaking

[jfsiii]

What's changed in this PR

Update to latest available semver: 7.3.2

• semver 5.x pulls in the entire library in one large file (~38k uncompressed / ~9k gz), when we might only use 1-2K.
• semver 7.0+ supports tree-shaking: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#700

Update paths to only import individual function(s) used instead of the entire library

• Getting the smaller bundle requires a different import style as shown in the docs
• Only changed code in public & common folders; not server. We could also update server as well for consistency, but I skipped because the new import style is more verbose and the filesize didn't seem as important on the server

Results

The build stats show a 10K+ improvement for initial page bundles #83020 (comment)

id	before	after	diff
ingestManager	386.2KB	373.9KB	-12.3KB
telemetry	63.5KB	50.1KB	-13.5KB
upgradeAssistant	74.5KB	60.5KB	-14.0KB
total			-39.7KB

The import paths look odd. Are they required?

I agree and, no, they're not strictly required. If you'd like me to revert to the prior style just drop a comment and I'll undo them.

The caveat is that the current style (in master & this PR) pulls in the entire semver library. In 7.x that added ~15K to the initial size. Some more details in the comments: #83020 (comment)

Possible issues

Moving 2 major versions. We're currently on 5.7 and the latest available is 7.3.

• changelog says 5.x (our current) to 6.0 should be safe: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#60
• There 6.x & 7.x changes all appear to be new features or bugfixes around the includePrerelease flag added in 5.6, but I'm not sure if those "fixes" will break existing code
  • https://github.com/npm/node-semver/blob/master/CHANGELOG.md#613
  • https://github.com/npm/node-semver/blob/master/CHANGELOG.md#722

Stats / screenshots

generated with node scripts/build_kibana_platform_plugins.js --profile --focus=ingestManager

Ingest Manager in `master`: imports entire `semver` lib, totals 40k+, only 1 large file (orange arc below)

Ingest Manager in PR after upgrade to 7: still imports entire lib. file size *increased* to ~60k, but now individual files are imported (orange arcs below)

Ingest Manager in PR after changing `import`s: total imported size down to ~20k. Can see individual imported files

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[jfsiii]

@tylersmalley @spalger I added you as reviewers to get any thoughts before I marked this ready for review and pinged other teams. Let me know if I should keep going, take a different approach, hold off entirely, or anything else that comes to mind. Thanks.

[spalger]

No objection to the upgrade, but I don't love the changes to imports. Relying on users to know that they should import the inner modules feels like it's setup to fail. It would be ideal if we could get this enforced with the module-migration custom eslint rule. If it's not worth enforcing then I wonder if it's worth making the change.

[jfsiii]

@spalger The import changes aren't strictly required to upgrade to 7.x. People can keep doing what they're doing now if they wish. They'll continue to pull in more than required but the library is a bit larger now so the amount of extra code is greater.

The initial commit which only upgraded semver (no import changes) failed b/c it tripped upgradeAssistants limit by ~5K. IIRC, it added about 10k to the initial bundle for them, dashboard, ingestManager, and some others.

I updated the paths because I thought a PR with ~10K/20% savings was more attractive than the alternative 10K/20% increase but it's definitely a team decision. I just wanted to make it easy to get the savings without having to do the work of updating the paths themselves.

[spalger]

Ah, okay, in that case I understand the justification for the extra changes regardless of whether we enforce them or not.

[nchaulet]

Nice to see the change in the bundle size 🚀

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[cjcenizal]

Looks like the version number logic in Upgrade Assistant is unaffected. Code LGTM.

[scottybollinger]

LGTM from Enterprise Search 👍

[darnautov]

ML changes LGTM

[jfsiii]

pinging @elastic/kibana-presentation @elastic/kibana-telemetry for 👀 when you have a moment

[ThomThomson]

Kibana Presentation changes LGTM. Seems to be just imports / usage of semver. Code only review

[TinaHeiligers]

Telemetry-related changes LGTM. Nice work on the bundle sizes 😄

[jfsiii]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 81a9999

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dashboard	170	185	+15
enterpriseSearch	464	468	+4
ingestManager	410	418	+8
ml	1558	1564	+6
monitoring	607	612	+5
telemetry	23	28	+5
upgradeAssistant	117	121	+4
total			+47

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	195.9KB	193.2KB	-2.7KB
enterpriseSearch	697.3KB	683.4KB	-14.0KB
ingestManager	1.1MB	1.1MB	+37.0B
ml	5.2MB	5.2MB	-13.6KB
monitoring	966.0KB	952.1KB	-13.9KB
total			-44.1KB

Distributable file count

id	before	after	diff
default	42860	42828	-32
oss	22511	22473	-38

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
ingestManager	384.6KB	372.4KB	-12.3KB
telemetry	63.5KB	50.1KB	-13.5KB
upgradeAssistant	74.5KB	60.5KB	-14.0KB
total			-39.7KB

History

• 💚 Build #87526 succeeded 263db68
• 💚 Build #87052 succeeded 213bb52
• 💔 Build #87030 failed 206b825
• 💔 Build #86990 failed a722532
• 💔 Build #86988 failed be97c5c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83020 or prevent reminders by adding the backport:skip label.