[Enterprise Search] Share Loading component #83246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
Feature:Plugins
release_note:skip
|
@daveyholler FYI on this. It's not as fancy as App Search's current loader but if we really want that I'd like to ask we postpone until 7.13+ and later investigate how to port a nicer animation without a 3rd party animation lib dependency. |
daveyholler
approved these changes
Nov 12, 2020
cee-chen
force-pushed
the
loading
branch
2 times, most recently
from
1f20e65 to
2e5ad24
Compare
|
I wonder if it's worth just sharing the one we have for DRY sake? |
|
WHAT! 🤯 I totally missed that lol, thanks Scotty. The only reason why I can think we wouldn't is if we do concretely plan on backporting the app search specific loader which has our logo and fancy animations. Lemme check w/ Davey rq. |
- for pages with shifting layouts or where skeletal loading doesn't make sense
|
@scottybollinger Here's WS with the new Loading component:
FYI that I use position absolute to center which works well with all our Layout views but less so with the non-Layout WS overview, so I added a temporary wrapper: a25d7dd
Let me know if that looks good to you! |
cee-chen
changed the title
scottybollinger
approved these changes
Nov 12, 2020
...plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.tsx
Outdated
Show resolved
Hide resolved
…h/components/engine/engine_router.tsx Co-authored-by: Scotty Bollinger <[email protected]>
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
that referenced
this pull request
Nov 13, 2020
* Add basic Loading component - for pages with shifting layouts or where skeletal loading doesn't make sense * Move Loading to shared components * Update WS to use new shared Loading component * Fix for non-Layout WS Overview page * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.tsx Co-authored-by: Scotty Bollinger <[email protected]> Co-authored-by: Scotty Bollinger <[email protected]> Co-authored-by: Scotty Bollinger <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 16, 2020
* master: [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462) [Enterprise Search] Share Loading component (elastic#83246) Consolidates Jest configuration files and scripts (elastic#82671) APM header changes (elastic#82870) [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727) [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889) [packerCache] fix gulp usage, don't archive node_modules (elastic#83327) Upgrade Node.js to version 12 (elastic#61587) [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734) [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011) [DOCS] Updates Discover docs (elastic#82773) [ML] Data frame analytics: Adds map view (elastic#81666) enables actions scoped within the stack to register at Basic license (elastic#82931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[Edit: PR was updated to have both App Search and Workplace Search share the same basic Loading component]
I'm adding a super basic loading spinner for views where skeletal views don't make sense. Also to make our migration a little bit faster so we don't have to think too much / change too much WRT dataLoading & early returns.
QA
if dataLoadingconditional onengine_router.tsxso it always returns Loading and go to any engine page.Checklist