Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updates Discover docs #82773

Merged
merged 14 commits into from
Nov 12, 2020
Merged

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Nov 5, 2020

Summary

This PR updates the Discover docs as follows:

  • Combines several topics into a single workflow
  • Updates images

Preview: https://kibana_82773.docs-preview.app.elstc.co/guide/en/kibana/master/discover.html

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Nov 5, 2020
@gchaps gchaps requested a review from KOTungseth November 9, 2020 17:57
that best display that data and build better dashboards.
*Discover* enables you to explore your data, find
hidden insights and relationships, and get answers to your questions.
You’ve added your data, and now you’re ready to dig in. You have questions about your data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of You have questions about your data, how about:

Discover helps you to answer these questions about your data:

  • What events were logged most recently?
  • What pages on your website contain a specific word or phrase?
  • What processes on your server take longer than 500 milliseconds to respond?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to have back-to-back bulleted lists at the top of the doc.

You’ve added your data, and now you’re ready to dig in. You have questions about your data.
What events were logged most recently? What pages on your website contain a
specific word or phrase? What processes on your server take longer than 500 milliseconds to respond?
This tutorial shows you how to use {kib} *Discover* to quickly search large amounts of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how we're supposed to reference Kibana apps? If so, we should open an issue to change these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


With *Discover*, you can:
You’ll learn to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is abrupt. How about:

In Discover, you can:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to use the wording "you'll learn to". I try to figure out softer wording.

docs/user/discover.asciidoc Outdated Show resolved Hide resolved

[role="screenshot"]
image::images/Discover-Start.png[Discover]


[float]
[[select-pattern]]
=== Set up your index pattern
=== Prerequisites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prerequisites should go right before the tasks.

docs/user/discover.asciidoc Outdated Show resolved Hide resolved
docs/user/discover.asciidoc Outdated Show resolved Hide resolved
docs/user/discover.asciidoc Outdated Show resolved Hide resolved
docs/user/discover.asciidoc Outdated Show resolved Hide resolved
docs/user/discover.asciidoc Show resolved Hide resolved
@gchaps gchaps requested a review from kertal November 10, 2020 01:08
@gchaps gchaps marked this pull request as ready for review November 10, 2020 01:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kertal
Copy link
Member

kertal commented Nov 11, 2020

ACK, thx will review today

docs/user/discover.asciidoc Outdated Show resolved Hide resolved
=== Step 5. Filter your data

Whereas the query defines the set of documents you are interested in,
filters enable you to zero in on different subsets of those documents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: to zero in .. nice

Whereas the query defines the set of documents you are interested in,
filters enable you to zero in on different subsets of those documents.
You can filter results to include or exclude specific fields,
filter by data type, filter for a value in a range, and more.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter for values, ranges, documents that contain or don't contain fields, yes ... but filtering by data type, I'm not 100% sure what that means in this case

@gchaps gchaps merged commit 0e565bf into elastic:master Nov 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 16, 2020
* master:
  [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462)
  [Enterprise Search] Share Loading component (elastic#83246)
  Consolidates Jest configuration files and scripts (elastic#82671)
  APM header changes (elastic#82870)
  [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727)
  [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889)
  [packerCache] fix gulp usage, don't archive node_modules (elastic#83327)
  Upgrade Node.js to version 12 (elastic#61587)
  [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734)
  [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011)
  [DOCS] Updates Discover docs (elastic#82773)
  [ML] Data frame analytics: Adds map view (elastic#81666)
  enables actions scoped within the stack to register at Basic license (elastic#82931)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 16, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 82773 or prevent reminders by adding the backport:skip label.

gchaps added a commit to gchaps/kibana that referenced this pull request Nov 16, 2020
* [DOCS] Updates Discover docs

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Incorporates review comments

* [DOCS] More changes based on edits

* [DOCS] Edits per lastest review

* [DOCS] Added redirects

Co-authored-by: Kaarina Tungseth <[email protected]>
gchaps added a commit that referenced this pull request Nov 16, 2020
* [DOCS] Updates Discover docs

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Incorporates review comments

* [DOCS] More changes based on edits

* [DOCS] Edits per lastest review

* [DOCS] Added redirects

Co-authored-by: Kaarina Tungseth <[email protected]>

Co-authored-by: Kaarina Tungseth <[email protected]>
gchaps added a commit that referenced this pull request Nov 16, 2020
* [DOCS] Updates Discover docs

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* Update docs/user/discover.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Incorporates review comments

* [DOCS] More changes based on edits

* [DOCS] Edits per lastest review

* [DOCS] Added redirects

Co-authored-by: Kaarina Tungseth <[email protected]>

Co-authored-by: Kaarina Tungseth <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants