Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solutions] Adds additional cypress tests and utils to value based lists (#83026) #83143

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

FrankHassanabad
Copy link
Contributor

Backports the following commits to 7.x:

… based lists (elastic#83026)

## Summary

Adds additional cypress tests and utils around value lists so that the percent of test driven development (TDD) possibilities will be easier for us to accomplish around bug fixes towards the next release.

* Changes and adds data test subjects within value based lists
* Fixes a bug where the list fixtures were not being converted to base64 before uploads within Cypress
* Adds a [CIDR](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing) fixture
* Adds tests for export, delete, close and open the dialog, and all the value based list types for the current modal. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +74.0B

Distributable file count

id before after diff
default 43120 43122 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit 05286a6 into elastic:7.x Nov 11, 2020
@FrankHassanabad FrankHassanabad deleted the backport/7.x/pr-83026 branch November 11, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants