[Security Solutions] Adds additional cypress tests and utils to value based lists #83026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
changed the title
FrankHassanabad
changed the title
FrankHassanabad
added
Feature:Detection Rules
FrankHassanabad
added
the
Team:Detections and Resp
peluja1012
approved these changes
Nov 10, 2020
peluja1012
reviewed
Nov 10, 2020
| @@ -0,0 +1,2 @@ | |||
| 192.168.100.14/24 | |||
|
|
|||
There was a problem hiding this comment.
Is this extra line here needed so you can split by \n here https://github.com/elastic/kibana/pull/83026/files#diff-c2160d09d0ff315067237ed293dda139f3846cf30b7673f77ce239f7e09b3c54R216?
There was a problem hiding this comment.
No, that's not needed. Thanks, removed it.
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Nov 11, 2020
… based lists (elastic#83026) ## Summary Adds additional cypress tests and utils around value lists so that the percent of test driven development (TDD) possibilities will be easier for us to accomplish around bug fixes towards the next release. * Changes and adds data test subjects within value based lists * Fixes a bug where the list fixtures were not being converted to base64 before uploads within Cypress * Adds a [CIDR](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing) fixture * Adds tests for export, delete, close and open the dialog, and all the value based list types for the current modal. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
that referenced
this pull request
Nov 11, 2020
… based lists (#83026) (#83143) ## Summary Adds additional cypress tests and utils around value lists so that the percent of test driven development (TDD) possibilities will be easier for us to accomplish around bug fixes towards the next release. * Changes and adds data test subjects within value based lists * Fixes a bug where the list fixtures were not being converted to base64 before uploads within Cypress * Adds a [CIDR](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing) fixture * Adds tests for export, delete, close and open the dialog, and all the value based list types for the current modal. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds additional cypress tests and utils around value lists so that the percent of test driven development (TDD) possibilities will be easier for us to accomplish around bug fixes towards the next release.
Checklist