Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Fix breadcrumbs #82594

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 4, 2020

Summary

Fix #81231

  • Added breadcrumb service
  • Added notice to legacy service patterns

ilm-breadcrumb

@jloleysens jloleysens added Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 4, 2020
@jloleysens jloleysens requested a review from sebelga November 4, 2020 11:53
@jloleysens jloleysens requested a review from a team as a code owner November 4, 2020 11:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
indexLifecycleManagement 110 111 +1

async chunks size

id before after diff
indexLifecycleManagement 223.9KB 224.4KB +472.0B

page load bundle size

id before after diff
indexLifecycleManagement 69.4KB 71.8KB +2.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! I haven't tested locally.

@jloleysens jloleysens merged commit db8f98c into elastic:master Nov 5, 2020
@jloleysens jloleysens deleted the ilm/add-breadcrumb-service branch November 5, 2020 10:24
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 5, 2020
* added breadcrumb service and call on ILM pages

* add notices to legacy pattern services

* fix jest tests and create mock
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 5, 2020
* master: (127 commits)
  [ILM] Fix breadcrumbs (elastic#82594)
  [UX]Swap env filter with percentile (elastic#82246)
  Add platform's missing READMEs (elastic#82268)
  [Discover] Adding uiMetric to track Visualize link click (elastic#82344)
  [Search] Add used index pattern name to the search agg error field (elastic#82604)
  improve client-side SO client get pooling (elastic#82603)
  [Security Solution] Unskips Overview tests (elastic#82459)
  Embeddables/migrations (elastic#82296)
  [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663)
  Moving reinstall function outside of promise.all (elastic#82672)
  Load choropleth layer correctly (elastic#82628)
  Master  backport elastic#81233 (elastic#82642)
  [Fleet] Allow snake cased Kibana assets (elastic#77515)
  Reduce saved objects authorization checks (elastic#82204)
  [data.search] Add request handler context and asScoped pattern (elastic#80775)
  [ML] Fixes formatting of fields in index data visualizer (elastic#82593)
  Usage collector readme (elastic#82548)
  [Lens] Visualization validation and better error messages (elastic#81439)
  [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490)
  chore(NA): install microdnf in UBI docker build only (elastic#82611)
  ...
jloleysens added a commit that referenced this pull request Nov 5, 2020
* added breadcrumb service and call on ILM pages

* add notices to legacy pattern services

* fix jest tests and create mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM doesn't update breadcrumbs
4 participants