[Discover] Adding uiMetric to track Visualize link click #82344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
majagrubic
changed the title
majagrubic
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
ACK, will review |
added 2 commits
November 4, 2020 08:52
kertal
reviewed
Nov 4, 2020
| @@ -67,6 +68,7 @@ export interface DiscoverServices { | |||
| getSavedSearchUrlById: (id: string) => Promise<string>; | |||
| getEmbeddableInjector: any; | |||
| uiSettings: IUiSettingsClient; | |||
| trackUiMetric: (metricType: UiStatsMetricType, eventName: string | string[]) => void; | |||
There was a problem hiding this comment.
I'd suggest, since trackUiMetric can be undefined, this should be considered in the type
Suggested change
| trackUiMetric: (metricType: UiStatsMetricType, eventName: string | string[]) => void; | |
| trackUiMetric?: (metricType: UiStatsMetricType, eventName: string | string[]) => void; |
| @@ -106,5 +113,6 @@ export async function buildServices( | |||
| timefilter: plugins.data.query.timefilter.timefilter, | |||
| toastNotifications: core.notifications.toasts, | |||
| uiSettings: core.uiSettings, | |||
| trackUiMetric, | |||
There was a problem hiding this comment.
you could save a few lines here
trackUiMetric: usageCollection?.reportUiStats.bind(usageCollection, 'discover')| * @param metricType | ||
| * @param eventName | ||
| */ | ||
| trackUiMetric: (metricType: UiStatsMetricType, eventName: string | string[]) => void; |
There was a problem hiding this comment.
Think, trackUiMetric should be optional
Suggested change
| trackUiMetric: (metricType: UiStatsMetricType, eventName: string | string[]) => void; | |
| trackUiMetric?: (metricType: UiStatsMetricType, eventName: string | string[]) => void; |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Nov 5, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 5, 2020
* master: (127 commits) [ILM] Fix breadcrumbs (elastic#82594) [UX]Swap env filter with percentile (elastic#82246) Add platform's missing READMEs (elastic#82268) [Discover] Adding uiMetric to track Visualize link click (elastic#82344) [Search] Add used index pattern name to the search agg error field (elastic#82604) improve client-side SO client get pooling (elastic#82603) [Security Solution] Unskips Overview tests (elastic#82459) Embeddables/migrations (elastic#82296) [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663) Moving reinstall function outside of promise.all (elastic#82672) Load choropleth layer correctly (elastic#82628) Master backport elastic#81233 (elastic#82642) [Fleet] Allow snake cased Kibana assets (elastic#77515) Reduce saved objects authorization checks (elastic#82204) [data.search] Add request handler context and asScoped pattern (elastic#80775) [ML] Fixes formatting of fields in index data visualizer (elastic#82593) Usage collector readme (elastic#82548) [Lens] Visualization validation and better error messages (elastic#81439) [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490) chore(NA): install microdnf in UBI docker build only (elastic#82611) ...
majagrubic
pushed a commit
that referenced
this pull request
Nov 5, 2020
…2697) * [Discover] Adding uiMetric around Visualize link click * Change metric name * Fixing wrong merge * Applying PR fixes Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #58747, one of the metrics we'd like to add is "count the number of times Visualize is clicked from the field list". This PR introduces
trackUiMetricto Discover and tracks metric for visualize link click.I tested this by querying
SavedObjectsAPI:<URL>/api/saved_objects/_find?type=ui-metricwhich returned a saved object with the following structure
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers