[deb/rpm] On upgrade, restart kibana service #82049

jbudz · 2020-10-29T16:41:25Z

This adds a new environment variable RESTART_ON_UPGRADE with a default value of true. In an upgrade scenario, Kibana will automatically restart.

Closes #9863

Release note:

Starting in 8.0 deb and rpm packages will restart on upgrade by default. This can be toggled by setting the environment variable RESTART_ON_UPGRADE in /etc/default/kibana

This adds a new environment variable KBN_RESTART_ON_UPGRADE with a default value of true. In an upgrade scenario Kibana will automatically restart. Closes elastic#9863

jbudz · 2020-10-29T16:43:43Z

Targeting 8.0 with a default restart behavior, 7.11 with support for the flag but no change. Needs docs changes and this is just the outline for testing ATM, review pending undraft

jbudz · 2020-10-29T21:34:55Z

defaults / KBN_RESTART_ON_UPGRADE="true"

jon@debd1:~$ sudo dpkg -i kibana-7.9.3-amd64.deb
Selecting previously unselected package kibana.
(Reading database ... 98911 files and directories currently installed.)
Preparing to unpack kibana-7.9.3-amd64.deb ...
Unpacking kibana (7.9.3) ...
Setting up kibana (7.9.3) ...
Processing triggers for systemd (245.4-4ubuntu3.2) ...
jon@debd1:~$ sudo dpkg -i kibana/target/kibana-8.0.0-SNAPSHOT-amd64.deb
(Reading database ... 185777 files and directories currently installed.)
Preparing to unpack .../kibana-8.0.0-SNAPSHOT-amd64.deb ...
Stopping kibana service... OK
Unpacking kibana (8.0.0-SNAPSHOT) over (7.9.3) ...
Setting up kibana (8.0.0-SNAPSHOT) ...
Installing new version of config file /etc/default/kibana ...
Installing new version of config file /etc/kibana/kibana.yml ...
Installing new version of config file /etc/systemd/system/kibana.service ...
Restarting kibana service... OK
jon@debd1:~$ service kibana status
● kibana.service - Kibana
     Loaded: loaded (/etc/systemd/system/kibana.service; disabled; vendor preset: enabled)
     Active: active (running) since Thu 2020-10-29 21:20:09 UTC; 9s ago
       Docs: https://www.elastic.co
   Main PID: 8279 (node)
      Tasks: 11 (limit: 9334)
     Memory: 193.8M
     CGroup: /system.slice/kibana.service
             └─8279 /usr/share/kibana/bin/../node/bin/node /usr/share/kibana/bin/../src/cli/dist --loggi>

Oct 29 21:20:09 debd1 systemd[1]: Started Kibana.

KBN_RESTART_ON_UPGRADE="false"

root@debd1:/home/jon#q dpkg -i kibana-7.9.3-amd64.deb
Selecting previously unselected package kibana.
(Reading database ... 98911 files and directories currently installed.)
Preparing to unpack kibana-7.9.3-amd64.deb ...
Unpacking kibana (7.9.3) ...
Setting up kibana (7.9.3) ...
Processing triggers for systemd (245.4-4ubuntu3.2) ...
root@debd1:/home/jon# echo 'KBN_RESTART_ON_UPGRADE="false"' > /etc/default/kibana
root@debd1:/home/jon# sudo dpkg -i kibana/target/kibana-8.0.0-SNAPSHOT-amd64.deb
(Reading database ... 185777 files and directories currently installed.)
Preparing to unpack .../kibana-8.0.0-SNAPSHOT-amd64.deb ...
Stopping kibana service... OK
Unpacking kibana (8.0.0-SNAPSHOT) over (7.9.3) ...
Setting up kibana (8.0.0-SNAPSHOT) ...

Configuration file '/etc/default/kibana'
 ==> Modified (by you or by a script) since installation.
 ==> Package distributor has shipped an updated version.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** kibana (Y/I/N/O/D/Z) [default=N] ?
Installing new version of config file /etc/kibana/kibana.yml ...
Installing new version of config file /etc/systemd/system/kibana.service ...
root@debd1:/home/jon# service kibana status
● kibana.service - Kibana
     Loaded: loaded (/etc/systemd/system/kibana.service; disabled; vendor preset: enabled)
     Active: inactive (dead)
       Docs: https://www.elastic.co

Oct 29 21:20:09 debd1 systemd[1]: Started Kibana.
Oct 29 21:20:52 debd1 systemd[1]: Stopping Kibana...
Oct 29 21:20:52 debd1 systemd[1]: kibana.service: Succeeded.
Oct 29 21:20:52 debd1 systemd[1]: Stopped Kibana.
root@debd1:/home/jon# ^C
root@debd1:/home/jon#

https://s3-us-west-1.amazonaws.com/kibana.budzenski.com/82049/0b1d1f0/kibana-8.0.0-SNAPSHOT-amd64.deb
https://s3-us-west-1.amazonaws.com/kibana.budzenski.com/82049/0b1d1f0/kibana-8.0.0-SNAPSHOT-x86_64.rpm

elasticmachine · 2020-10-29T21:35:19Z

Pinging @elastic/kibana-operations (Team:Operations)

tylersmalley · 2020-10-30T00:34:27Z

I believe in the past we discussed removing any interaction with the service in our scripts. Have you had different thoughts? What does ES currently do?

jbudz · 2020-10-30T13:25:02Z

This is modeled off ES, the main difference is UPGRADE_ON_RESTART in ES vs KBN_UPGRADE_ON_RESTART here. We could make them both the same name now that I'm thinking about it, environment variables are isolated in individual services.

This should remove interaction by default on the builds above (but with a restart) but we were referring to not stopping the service right? I'll get some builds together and linky here with it removed to see how it runs. I'm mainly concerned with the unknowns - server routes going stale, not sure if the the public files are cached in memory.

jbudz · 2020-11-02T11:56:33Z

@elasticmachine merge upstream

…os/restart-on-upgrade

jbudz · 2020-11-02T16:00:05Z

I replaced KBN_RESTART_ON_UPGRADE with RESTART_ON_UPGRADE to avoid any confusion and to be consistent with elasticsearch. The variable is scoped to the service so it shouldn't have any conflicts.

For not stopping the service - I did an install where the service isn't stopped and didn't run into any issues. There were minimal code changes however, and another reason I'm trending towards this is migrations won't run. Any thoughts?

jbudz · 2020-11-04T17:57:52Z

@elasticmachine merge upstream

jbudz · 2020-11-06T13:06:37Z

@elasticmachine merge upstream

tylersmalley

LGTM - manually tested upgrade from 7.9.3

jbudz · 2020-11-09T13:08:09Z

@elasticmachine merge upstream

kibanamachine · 2020-11-09T14:53:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 097d270

Metrics [docs]

✅ unchanged

History

💚 Build #86381 succeeded f36aa81
💚 Build #85891 succeeded 245b506
💚 Build #85239 succeeded 0600828
💚 Build #85117 succeeded 3b2b22d
💚 Build #84690 succeeded 0b1d1f0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2020-11-10T16:04:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2020-11-11T16:14:38Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

#82971) * [deb/rpm] On upgrade, restart kibana service (#82049) Co-authored-by: Kibana Machine <[email protected]> * default restart behavior to off in 7.x Co-authored-by: Kibana Machine <[email protected]>

jbudz · 2020-11-11T18:51:51Z

7.11: 558ca4b

< 8.0 will have a default behavior of not restarting.

[deb/rpm] On upgrade, restart kibana service

e07f2d4

This adds a new environment variable KBN_RESTART_ON_UPGRADE with a default value of true. In an upgrade scenario Kibana will automatically restart. Closes elastic#9863

jbudz added Team:Operations Team label for Operations Team v8.0.0 v7.11.0 labels Oct 29, 2020

jbudz added 4 commits October 29, 2020 12:50

fix spacing, define envFile

f3dc6e7

,

6b8eada

fix postinst envFile ref

799fda4

Merge branch 'master' into os/restart-on-upgrade

0b1d1f0

jbudz marked this pull request as ready for review October 29, 2020 21:35

jbudz requested a review from a team as a code owner October 29, 2020 21:35

jbudz added the release_note:enhancement label Oct 29, 2020

kibanamachine and others added 4 commits November 2, 2020 06:56

Merge branch 'master' into os/restart-on-upgrade

3b2b22d

reuse scoped RESTART_ON_UPGRADE instead of KBN_RESTART_ON_UPGRADE

361712c

Merge branch 'os/restart-on-upgrade' of github.com:jbudz/kibana into …

ecb18c4

…os/restart-on-upgrade

Merge branch 'master' into os/restart-on-upgrade

0600828

Merge branch 'master' into os/restart-on-upgrade

245b506

Merge branch 'master' into os/restart-on-upgrade

f36aa81

tylersmalley approved these changes Nov 6, 2020

View reviewed changes

Merge branch 'master' into os/restart-on-upgrade

097d270

jbudz merged commit 0a71f2c into elastic:master Nov 9, 2020

jbudz deleted the os/restart-on-upgrade branch November 9, 2020 15:50

jbudz added a commit to jbudz/kibana that referenced this pull request Nov 9, 2020

[deb/rpm] On upgrade, restart kibana service (elastic#82049)

7395355

Co-authored-by: Kibana Machine <[email protected]>

jbudz mentioned this pull request Nov 9, 2020

[7.x] [deb/rpm] On upgrade, support restarting kibana service (#82049) #82971

Merged

jbudz added the backport pending label Nov 9, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 10, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2020

jbudz added backported and removed backport pending labels Nov 11, 2020

jbudz mentioned this pull request Nov 17, 2020

Kibana "inactive (dead)" after an update #15470

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[deb/rpm] On upgrade, restart kibana service #82049

[deb/rpm] On upgrade, restart kibana service #82049

jbudz commented Oct 29, 2020 •

edited

Loading

jbudz commented Oct 29, 2020

jbudz commented Oct 29, 2020 •

edited

Loading

elasticmachine commented Oct 29, 2020

tylersmalley commented Oct 30, 2020

jbudz commented Oct 30, 2020 •

edited

Loading

jbudz commented Nov 2, 2020

jbudz commented Nov 2, 2020 •

edited

Loading

jbudz commented Nov 4, 2020

jbudz commented Nov 6, 2020

tylersmalley left a comment

jbudz commented Nov 9, 2020

kibanamachine commented Nov 9, 2020

kibanamachine commented Nov 10, 2020

kibanamachine commented Nov 11, 2020

jbudz commented Nov 11, 2020 •

edited

Loading

[deb/rpm] On upgrade, restart kibana service #82049

[deb/rpm] On upgrade, restart kibana service #82049

Conversation

jbudz commented Oct 29, 2020 • edited Loading

jbudz commented Oct 29, 2020

jbudz commented Oct 29, 2020 • edited Loading

elasticmachine commented Oct 29, 2020

tylersmalley commented Oct 30, 2020

jbudz commented Oct 30, 2020 • edited Loading

jbudz commented Nov 2, 2020

jbudz commented Nov 2, 2020 • edited Loading

jbudz commented Nov 4, 2020

jbudz commented Nov 6, 2020

tylersmalley left a comment

Choose a reason for hiding this comment

jbudz commented Nov 9, 2020

kibanamachine commented Nov 9, 2020

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Nov 10, 2020

kibanamachine commented Nov 11, 2020

jbudz commented Nov 11, 2020 • edited Loading

jbudz commented Oct 29, 2020 •

edited

Loading

jbudz commented Oct 29, 2020 •

edited

Loading

jbudz commented Oct 30, 2020 •

edited

Loading

jbudz commented Nov 2, 2020 •

edited

Loading

jbudz commented Nov 11, 2020 •

edited

Loading