Merge branch 'master' into os/restart-on-upgrade

.github/CODEOWNERS

@@ -171,8 +171,6 @@
 /x-pack/test/functional/apps/maps/ @elastic/kibana-gis
 /x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
 /x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis
-#CC# /src/legacy/core_plugins/region_map @elastic/kibana-gis
-#CC# /src/legacy/core_plugins/tile_map @elastic/kibana-gis
 #CC# /src/plugins/maps_legacy/ @elastic/kibana-gis
 #CC# /x-pack/plugins/file_upload @elastic/kibana-gis
 #CC# /x-pack/plugins/maps_legacy_licensing @elastic/kibana-gis

docs/developer/plugin-list.asciidoc

@@ -38,8 +38,8 @@ NOTE:
 |The Charts plugin is a way to create easier integration of shared colors, themes, types and other utilities across all Kibana charts and visualizations.
 
 
-|{kib-repo}blob/{branch}/src/plugins/console[console]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/console/README.md[console]
+|Console provides the user with tools for storing and executing requests against Elasticsearch.
 
 
 |<<kibana-dashboard-plugin>>
@@ -134,8 +134,8 @@ in Kibana, e.g. visualizations. It has the form of a flyout panel.
 |WARNING: Missing README.
 
 
-|{kib-repo}blob/{branch}/src/plugins/maps_legacy[mapsLegacy]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/maps_legacy/README.md[mapsLegacy]
+|Internal objects used by the Coordinate, Region, and Vega visualizations.
 
 
 |{kib-repo}blob/{branch}/src/plugins/navigation/README.md[navigation]
@@ -147,8 +147,8 @@ It also provides a stateful version of it on the start contract.
 |WARNING: Missing README.
 
 
-|{kib-repo}blob/{branch}/src/plugins/region_map[regionMap]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/region_map/README.md[regionMap]
+|Create choropleth maps. Display the results of a term-aggregation as e.g. countries, zip-codes, states.
 
 
 |{kib-repo}blob/{branch}/src/plugins/saved_objects[savedObjects]
@@ -180,8 +180,8 @@ so they can properly protect the data within their clusters.
 |This plugin adds the Advanced Settings section for the Usage and Security Data collection (aka Telemetry).
 
 
-|{kib-repo}blob/{branch}/src/plugins/tile_map[tileMap]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/tile_map/README.md[tileMap]
+|Create a coordinate map. Display the results of a geohash_tile aggregation as bubbles, rectangles, or heatmap color blobs.
 
 
 |{kib-repo}blob/{branch}/src/plugins/timelion/README.md[timelion]
@@ -307,8 +307,8 @@ Failure to have auth enabled in Kibana will make for a broken UI. UI-based error
 |WARNING: Missing README.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/console_extensions[consoleExtensions]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/console_extensions/README.md[consoleExtensions]
+|This plugin provides autocomplete definitions of licensed APIs to the OSS Console plugin.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/cross_cluster_replication/README.md[crossClusterReplication]
@@ -355,8 +355,8 @@ and actions.
 |WARNING: Missing README.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/file_upload[fileUpload]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/file_upload/README.md[fileUpload]
+|Backend and core front-end react-components for GeoJson file upload. Only supports the Maps plugin.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/global_search/README.md[globalSearch]
@@ -376,8 +376,9 @@ or dashboards from the Kibana instance, from both server and client-side plugins
 |This is the main source folder of the Graph plugin. It contains all of the Kibana server and client source code. x-pack/test/functional/apps/graph contains additional functional tests.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/grokdebugger[grokdebugger]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/grokdebugger/README.md[grokdebugger]
+|This plugin helps users define Grok patterns,
+which are particularly useful for ingesting logs.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/index_lifecycle_management/README.md[indexLifecycleManagement]
@@ -406,8 +407,8 @@ the infrastructure monitoring use-case within Kibana.
 |Run all tests from the x-pack root directory
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/license_management[licenseManagement]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/license_management/README.md[licenseManagement]
+|This plugin enables users to activate a trial license, downgrade to Basic, and upload a new license.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/licensing/README.md[licensing]
@@ -444,12 +445,12 @@ Elastic.
 |This plugin provides shared components and services for use across observability solutions, as well as the observability landing page UI.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/painless_lab[painlessLab]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/painless_lab/README.md[painlessLab]
+|This plugin helps users learn how to use the Painless scripting language.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/remote_clusters[remoteClusters]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/remote_clusters/README.md[remoteClusters]
+|This plugin helps users manage their remote clusters, which enable cross-cluster search and cross-cluster replication.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/reporting/README.md[reporting]
@@ -460,8 +461,11 @@ Elastic.
 |Welcome to the Kibana rollup plugin! This plugin provides Kibana support for Elasticsearch's rollup feature. Please refer to the Elasticsearch documentation to understand rollup indices and how to create rollup jobs.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/searchprofiler[searchprofiler]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/searchprofiler/README.md[searchprofiler]
+|The search profiler consumes the Profile API
+by sending a search API with profile: true enabled in the request body. The response contains
+detailed information on how Elasticsearch executed the search request. People use this information
+to understand why a search request might be slow.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/security/README.md[security]
@@ -488,8 +492,8 @@ the alertTypes by the Stack in the alerting plugin, register associated HTTP
 routes, etc.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/task_manager[taskManager]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/task_manager/README.md[taskManager]
+|The task manager is a generic system for running background tasks.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/telemetry_collection_xpack/README.md[telemetryCollectionXpack]
@@ -513,8 +517,9 @@ As a developer you can reuse and extend built-in alerts and actions UI functiona
 |Registers commercially licensed generic actions like per panel time range and contains some code that supports drilldown work.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/upgrade_assistant[upgradeAssistant]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/upgrade_assistant/README.md[upgradeAssistant]
+|Upgrade Assistant helps users prepare their Stack for being upgraded to the next major. Its primary
+purposes are to:
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/uptime/README.md[uptime]

src/core/server/http/integration_tests/router.test.ts

@@ -384,7 +384,7 @@ describe('Options', () => {
     });
 
     describe('idleSocket', () => {
-      it('should timeout if payload sending has too long of an idle period', async () => {
+      it.skip('should timeout if payload sending has too long of an idle period', async () => {
         const { server: innerServer, createRouter } = await server.setup(setupDeps);
         const router = createRouter('/');
 

src/plugins/console/README.md

@@ -0,0 +1,5 @@
+# Console
+
+## About
+
+Console provides the user with tools for storing and executing requests against Elasticsearch.

src/plugins/maps_legacy/README.md

@@ -0,0 +1,7 @@
+# Maps legacy
+
+Internal objects used by the Coordinate, Region, and Vega visualizations. 
+
+It exports the default Leaflet-based map and exposes the connection to the Elastic Maps service.
+
+This plugin is targeted for removal in 8.0.

src/plugins/region_map/README.md

@@ -0,0 +1,5 @@
+# Region map visualization
+
+Create choropleth maps. Display the results of a term-aggregation as e.g. countries, zip-codes, states. 
+
+This plugin is targeted for removal in 8.0.

src/plugins/tile_map/README.md

@@ -0,0 +1,5 @@
+# Coordinate map visualization
+
+Create a coordinate map. Display the results of a geohash_tile aggregation as bubbles, rectangles, or heatmap color blobs.
+
+This plugin is targeted for removal in 8.0.

src/plugins/vis_type_tagcloud/public/components/tag_cloud_chart.tsx

@@ -45,7 +45,9 @@ export const TagCloudChart = ({
   const visController = useRef<any>(null);
 
   useEffect(() => {
-    visController.current = new TagCloudVisualization(chartDiv.current, colors, fireEvent);
+    if (chartDiv.current) {
+      visController.current = new TagCloudVisualization(chartDiv.current, colors, fireEvent);
+    }
     return () => {
       visController.current.destroy();
       visController.current = null;

src/plugins/vis_type_timelion/public/timelion_vis_renderer.tsx

@@ -42,12 +42,6 @@ export const getTimelionVisRenderer: (
     const [seriesList] = visData.sheet;
     const showNoResult = !seriesList || !seriesList.list.length;
 
-    if (showNoResult) {
-      // send the render complete event when there is no data to show
-      // to notify that a chart is updated
-      handlers.done();
-    }
-
     render(
       <VisualizationContainer handlers={handlers} showNoResult={showNoResult}>
         <KibanaContextProvider services={{ ...deps }}>

src/plugins/vis_type_vislib/public/area.ts

@@ -37,22 +37,20 @@ import {
   getConfigCollections,
 } from './utils/collections';
 import { getAreaOptionTabs, countLabel } from './utils/common_config';
-import { createVislibVisController } from './vis_controller';
-import { VisTypeVislibDependencies } from './plugin';
 import { Rotates } from '../../charts/public';
-import { VIS_EVENT_TO_TRIGGER } from '../../../plugins/visualizations/public';
+import { BaseVisTypeOptions, VIS_EVENT_TO_TRIGGER } from '../../../plugins/visualizations/public';
+import { toExpressionAst } from './to_ast';
+import { BasicVislibParams } from './types';
 
-export const createAreaVisTypeDefinition = (deps: VisTypeVislibDependencies) => ({
+export const areaVisTypeDefinition: BaseVisTypeOptions<BasicVislibParams> = {
   name: 'area',
   title: i18n.translate('visTypeVislib.area.areaTitle', { defaultMessage: 'Area' }),
   icon: 'visArea',
   description: i18n.translate('visTypeVislib.area.areaDescription', {
     defaultMessage: 'Emphasize the quantity beneath a line chart',
   }),
-  visualization: createVislibVisController(deps),
-  getSupportedTriggers: () => {
-    return [VIS_EVENT_TO_TRIGGER.filter, VIS_EVENT_TO_TRIGGER.brush];
-  },
+  getSupportedTriggers: () => [VIS_EVENT_TO_TRIGGER.filter, VIS_EVENT_TO_TRIGGER.brush],
+  toExpressionAst,
   visConfig: {
     defaults: {
       type: 'area',
@@ -131,9 +129,6 @@ export const createAreaVisTypeDefinition = (deps: VisTypeVislibDependencies) =>
       labels: {},
     },
   },
-  events: {
-    brush: { disabled: false },
-  },
   editorConfig: {
     collections: getConfigCollections(),
     optionTabs: getAreaOptionTabs(),
@@ -190,4 +185,4 @@ export const createAreaVisTypeDefinition = (deps: VisTypeVislibDependencies) =>
       },
     ]),
   },
-});
+};

src/plugins/vis_type_vislib/public/components/options/gauge/index.tsx

@@ -60,4 +60,6 @@ function GaugeOptions(props: VisOptionsProps<GaugeVisParams>) {
   );
 }
 
-export { GaugeOptions };
+// default export required for React.Lazy
+// eslint-disable-next-line import/no-default-export
+export { GaugeOptions as default };

src/plugins/vis_type_vislib/public/components/options/heatmap/index.tsx

@@ -185,4 +185,6 @@ function HeatmapOptions(props: VisOptionsProps<HeatmapVisParams>) {
   );
 }
 
-export { HeatmapOptions };
+// default export required for React.Lazy
+// eslint-disable-next-line import/no-default-export
+export { HeatmapOptions as default };

src/plugins/vis_type_vislib/public/components/options/index.tsx

@@ -0,0 +1,51 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { lazy } from 'react';
+
+import { VisOptionsProps } from 'src/plugins/vis_default_editor/public';
+import { ValidationVisOptionsProps } from '../common';
+import { GaugeVisParams } from '../../gauge';
+import { PieVisParams } from '../../pie';
+import { BasicVislibParams } from '../../types';
+import { HeatmapVisParams } from '../../heatmap';
+
+const GaugeOptionsLazy = lazy(() => import('./gauge'));
+const PieOptionsLazy = lazy(() => import('./pie'));
+const PointSeriesOptionsLazy = lazy(() => import('./point_series'));
+const HeatmapOptionsLazy = lazy(() => import('./heatmap'));
+const MetricsAxisOptionsLazy = lazy(() => import('./metrics_axes'));
+
+export const GaugeOptions = (props: VisOptionsProps<GaugeVisParams>) => (
+  <GaugeOptionsLazy {...props} />
+);
+
+export const PieOptions = (props: VisOptionsProps<PieVisParams>) => <PieOptionsLazy {...props} />;
+
+export const PointSeriesOptions = (props: ValidationVisOptionsProps<BasicVislibParams>) => (
+  <PointSeriesOptionsLazy {...props} />
+);
+
+export const HeatmapOptions = (props: VisOptionsProps<HeatmapVisParams>) => (
+  <HeatmapOptionsLazy {...props} />
+);
+
+export const MetricsAxisOptions = (props: ValidationVisOptionsProps<BasicVislibParams>) => (
+  <MetricsAxisOptionsLazy {...props} />
+);

src/plugins/vis_type_vislib/public/components/options/metrics_axes/index.test.tsx

@@ -21,7 +21,7 @@ import React from 'react';
 import { mount, shallow } from 'enzyme';
 
 import { IAggConfig, IAggType } from 'src/plugins/data/public';
-import { MetricsAxisOptions } from './index';
+import MetricsAxisOptions from './index';
 import { BasicVislibParams, SeriesParam, ValueAxis } from '../../../types';
 import { ValidationVisOptionsProps } from '../../common';
 import { Positions } from '../../../utils/collections';