Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Usage Collection] Kibana Overview Page UI Metrics #81937

Merged
merged 8 commits into from
Dec 8, 2020
Merged

[Usage Collection] Kibana Overview Page UI Metrics #81937

merged 8 commits into from
Dec 8, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 28, 2020 •
edited
Loading

Summary

Blocked by #81827.

UI Metrics added:

App: kibana_overview

Type Name Description
click app_card_${appId} when a user clicks on one of the Kibana app cards (i.e dashboard, discover, etc)
click solution_panel_${solutionId} when a user clicks on one of the solution cards
click ingest_data_card_${featureId} when a user clicks on one of the options in the "Ingest data" section shown when other solutions are not available
click manage_data_card_${featureId} when a user clicks on one of the options in the "Manage data" section shown when other solutions are not available
click set_kibana_overview_as_default_route when a user clicks the Make this my landing page button and sets the home page as their defaultRoute in advanced settings
click change_to_different_default_route when a user clicks the Display a different page on log in button indicating intent to change their landing page

For maintainers

@alexfrancoeur
Copy link

@AlonaNadler I know you didn't come up with usage analytics requirements for this page, so let us know if you'd prefer anything different. I'm happy to provide more details on what these mean and what the output will be in upcoming releases. Here's an example for the homepage, @cqliu1 is taking a very similar approach #81827 (review)

@cqliu1
Copy link
Contributor Author

cqliu1 commented Nov 10, 2020

@elasticmachine merge upstream

@cqliu1 cqliu1 marked this pull request as ready for review November 10, 2020 14:36
@cqliu1 cqliu1 requested a review from a team November 10, 2020 14:36
@cqliu1 cqliu1 added release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team labels Nov 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@cqliu1 cqliu1 requested a review from a team November 10, 2020 14:38
ryankeairns
ryankeairns approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexfrancoeur I presume it's safe to merge this basic set. We can always add additional metrics later, right?

@cqliu1 is needing to make a clean cut to her new (old) team, so it would be nice to wrap this up for her.

TinaHeiligers
TinaHeiligers approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM

@cqliu1
Copy link
Contributor Author

cqliu1 commented Nov 19, 2020

@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented Dec 7, 2020

@elasticmachine merge upstream

@cqliu1
Copy link
Contributor Author

cqliu1 commented Dec 7, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaOverview 32 42 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaOverview 27.3KB 27.9KB +622.0B

Distributable file count

id before after diff
default 46934 47694 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaOverview 39.3KB 49.4KB +10.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexfrancoeur
Copy link

Apologies for never responding to this a few weeks back. +1 on finishing this one up as is

@cqliu1 cqliu1 merged commit 99ae137 into elastic:master Dec 8, 2020
@cqliu1 cqliu1 deleted the telemetry/kibana-overview branch December 8, 2020 01:52
@cqliu1 cqliu1 mentioned this pull request Dec 8, 2020
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 8, 2020
@cqliu1 @kibanamachine
[Usage Collection] Kibana Overview Page UI Metrics (elastic#81937)
0071f5c 
Co-authored-by: Kibana Machine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 8, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/fix-hide-…
d04f61b 
…or-disable-searchable-snapshot-fields

* 'master' of github.com:elastic/kibana: (29 commits)
  HTTP CRUD+ API for Index Patterns (elastic#83576)
  Don't list packages in devDependencies already listed in dependencies (elastic#85120)
  Remove unused devDependencies (elastic#85121)
  [ILM] Reposition form toggles (elastic#85143)
  [APM] Make sure jest script can be run from anywhere (elastic#85111)
  Add EuiButtonEmptyTo components (elastic#85213)
  skip flaky suite (elastic#85216)
  skip flaky suite (elastic#83775)
  skip flaky suite (elastic#83774)
  skip flaky suite (elastic#83773)
  skip flaky suite (elastic#83793)
  skip flaky suite (elastic#85215)
  skip flaky suite (elastic#85217)
  [Usage Collection] Kibana Overview Page UI Metrics (elastic#81937)
  [Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API (elastic#84604)
  skip flaky suite (elastic#85208)
  [Security Solutions][Detection Engine] Fixes cypress errors by using latest signals mapping (elastic#84600)
  Small fixes to Kibana search bar (elastic#85079)
  Change link text to say Fleet (elastic#85083)
  [Metrics UI] Refactor Process List API to fetch only top processes (elastic#84716)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
cqliu1 added a commit that referenced this pull request Dec 8, 2020
@cqliu1 @kibanamachine
[7.x] [Usage Collection] Kibana Overview Page UI Metrics (#81937) (#8…
b03ae1c 
…5219)

Co-authored-by: Kibana Machine <[email protected]>
@lukeelmers lukeelmers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:KibanaTelemetry labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cqliu1 @alexfrancoeur @elasticmachine @kibanamachine @ryankeairns @TinaHeiligers @lukeelmers