Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage Collection] Home Page UI Metrics #81827

Merged
merged 7 commits into from
Nov 2, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 27, 2020

Summary

Closes #74428.

UI Metrics added:

App: Kibana_home

Type Name Description
click solution_panel_${solutionId} when a user clicks on one of the solutions
click ingest_data_card_${featureId} when a user clicks on one of the options in the "Ingest data" section
click manage_data_card_${featureId} when a user clicks on one of the options in the "Manage data" section
click set_home_as_default_route when a user clicks the Make this my landing page button and sets the home page as their defaultRoute in advanced settings
click change_to_different_default_route when a user clicks the Display a different page on log in button indicating intent to change their landing page

For maintainers

@cqliu1 cqliu1 added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:KibanaTelemetry v7.11.0 v8.0.0 labels Oct 28, 2020
@cqliu1 cqliu1 marked this pull request as ready for review October 28, 2020 18:47
@cqliu1 cqliu1 requested a review from a team as a code owner October 28, 2020 18:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@cqliu1 cqliu1 requested review from a team and alexfrancoeur October 28, 2020 18:48
Copy link

@alexfrancoeur alexfrancoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Metrics look good to me, when we can parse ui_metrics differently in the upcoming release (cc: @TinaHeiligers). Confirming that they answer the original questions. Thanks Catherine!

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and verified everything works as expected by running the PR locally.
LGTM for ui_metrics implementation.

We're capturing quite a few additional objects in the ui_metrics.Kibana_home key:

`ui_metrics.Kibana_home`
"ui_metric": {
  "Kibana_home": [
    {
      "key": "sampleDataDecline",
      "value": 1
    },
    {
      "key": "welcomeScreenMount",
      "value": 1
    },
    {
      "key": "manage_data_card_console",
      "value": 1
    },
    {
      "key": "set_home_as_default_route",
      "value": 3
    },
    {
      "key": "solution_panel_observability",
      "value": 1
    },
    {
      "key": "solution_panel_enterpriseSearch",
      "value": 1
    },
    {
      "key": "ingest_data_card_ingestManager",
      "value": 1
    },
    {
      "key": "ingest_data_card_home_tutorial_directory",
      "value": 1
    },
    {
      "key": "solution_panel_securitySolution",
      "value": 1
    },
    {
      "key": "ingest_data_card_ml_file_data_visualizer",
      "value": 1
    },
    {
      "key": "manage_data_card_snapshot_restore",
      "value": 1
    },
    {
      "key": "manage_data_card_monitoring",
      "value": 1
    },
    {
      "key": "solution_panel_kibana",
      "value": 5
    },
    {
      "key": "manage_data_card_security",
      "value": 1
    },
    {
      "key": "change_to_different_default_route",
      "value": 3
    },
    {
      "key": "manage_data_card_index_lifecycle_management",
      "value": 1
    }
  ]
}

@TinaHeiligers
Copy link
Contributor

when we can parse ui_metrics differently in the upcoming release
@alexfrancoeur I'll respond in #74428 so as not to clutter this PR.

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh
Copy link
Member

Bamieh commented Nov 2, 2020

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team November 2, 2020 11:24
@ryankeairns
Copy link
Contributor

@myasonik can you take a look at this one on behalf of Core UI? Thanks!

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change for how we collect the metrics, otherwise GTG!

Comment on lines 77 to 78
createAppNavigationHandler(feature.path)(event);
trackUiMetric(METRIC_TYPE.CLICK, `ingest_data_card_${feature.id}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we want to swap these two lines?

createAppNavigationHandler bails if someone goes to open the link in a new tab but we could still collect that metric.

Comment on lines 66 to 67
createAppNavigationHandler(feature.path)(event);
trackUiMetric(METRIC_TYPE.CLICK, `manage_data_card_${feature.id}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, swap?

Comment on lines 74 to 75
createAppNavigationHandler(solution.path)(event);
trackUiMetric(METRIC_TYPE.CLICK, `solution_panel_${solution.id}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last instance, swap?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
home 347.6KB 348.4KB +835.0B

page load bundle size

id before after diff
kibanaReact 131.5KB 131.7KB +230.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit d9eef77 into elastic:master Nov 2, 2020
@cqliu1 cqliu1 deleted the telemetry/home-page branch November 2, 2020 23:32
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Nov 3, 2020
* Added telemetry for the home page

* Added check for click handlers in overview page footer

* Fixed ts error

* Updated snapshots

* Applied feedback

Co-authored-by: Kibana Machine <[email protected]>
cqliu1 added a commit that referenced this pull request Nov 3, 2020
* Added telemetry for the home page

* Added check for click handlers in overview page footer

* Fixed ts error

* Updated snapshots

* Applied feedback

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@lukeelmers lukeelmers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:KibanaTelemetry labels Oct 1, 2021
@cqliu1 cqliu1 restored the telemetry/home-page branch June 8, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic homepage analytics
9 participants