-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Usage Collection] Home Page UI Metrics #81827
Conversation
ee81845
to
2122b89
Compare
Pinging @elastic/kibana-core-ui (Team:Core UI) |
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics look good to me, when we can parse ui_metrics
differently in the upcoming release (cc: @TinaHeiligers). Confirming that they answer the original questions. Thanks Catherine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and verified everything works as expected by running the PR locally.
LGTM for ui_metrics
implementation.
We're capturing quite a few additional objects in the ui_metrics.Kibana_home
key:
`ui_metrics.Kibana_home`
"ui_metric": {
"Kibana_home": [
{
"key": "sampleDataDecline",
"value": 1
},
{
"key": "welcomeScreenMount",
"value": 1
},
{
"key": "manage_data_card_console",
"value": 1
},
{
"key": "set_home_as_default_route",
"value": 3
},
{
"key": "solution_panel_observability",
"value": 1
},
{
"key": "solution_panel_enterpriseSearch",
"value": 1
},
{
"key": "ingest_data_card_ingestManager",
"value": 1
},
{
"key": "ingest_data_card_home_tutorial_directory",
"value": 1
},
{
"key": "solution_panel_securitySolution",
"value": 1
},
{
"key": "ingest_data_card_ml_file_data_visualizer",
"value": 1
},
{
"key": "manage_data_card_snapshot_restore",
"value": 1
},
{
"key": "manage_data_card_monitoring",
"value": 1
},
{
"key": "solution_panel_kibana",
"value": 5
},
{
"key": "manage_data_card_security",
"value": 1
},
{
"key": "change_to_different_default_route",
"value": 3
},
{
"key": "manage_data_card_index_lifecycle_management",
"value": 1
}
]
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
@myasonik can you take a look at this one on behalf of Core UI? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change for how we collect the metrics, otherwise GTG!
createAppNavigationHandler(feature.path)(event); | ||
trackUiMetric(METRIC_TYPE.CLICK, `ingest_data_card_${feature.id}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to swap these two lines?
createAppNavigationHandler
bails if someone goes to open the link in a new tab but we could still collect that metric.
createAppNavigationHandler(feature.path)(event); | ||
trackUiMetric(METRIC_TYPE.CLICK, `manage_data_card_${feature.id}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, swap?
createAppNavigationHandler(solution.path)(event); | ||
trackUiMetric(METRIC_TYPE.CLICK, `solution_panel_${solution.id}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last instance, swap?
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
* Added telemetry for the home page * Added check for click handlers in overview page footer * Fixed ts error * Updated snapshots * Applied feedback Co-authored-by: Kibana Machine <[email protected]>
* Added telemetry for the home page * Added check for click handlers in overview page footer * Fixed ts error * Updated snapshots * Applied feedback Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
Closes #74428.
UI Metrics added:
App:
Kibana_home
click
solution_panel_${solutionId}
click
ingest_data_card_${featureId}
click
manage_data_card_${featureId}
click
set_home_as_default_route
Make this my landing page
button and sets the home page as theirdefaultRoute
in advanced settingsclick
change_to_different_default_route
Display a different page on log in
button indicating intent to change their landing pageFor maintainers